feat(prometheus): allow passing a *ServeMux on NewReporter #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
prometheuspackage, theNewReporterfunction exposes an HTTP server for the metrics. It's great, but if you also have other routes to exposes on your app, you need to create another HTTP server to handle those.I propose adding a
ServerMuxoption so that user of the lib can expose other endpoints on the same HTTP server started. I'm thinking of other observability related endpoints such as pprof (which is my very use case).