Open
Conversation
Adds a post-processing sed to handle __dirname in ESM environments where it's not defined (Cloudflare Workers, Node ESM, Deno, Bun). Follows the same approach as the existing document.currentScript fix. Fixes uber#216
Author
|
One note on approach — another option would be updating to Emscripten 3.x+ and adding Went with the sed patch here since:
Happy to take either direction if maintainers prefer the toolchain update instead! |
artur19simonyan81-rgb
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Ran into this issue deploying to Cloudflare Workers and dug into the root cause.
The problem
The generated
libh3.jsuses__dirnamefor Node detection:This breaks in ESM environments where
__dirnamedoesn't exist — Cloudflare Workers, Node ESM, Deno, Bun, etc.The fix
Added a sed replacement in the build script (same approach as the existing
document.currentScriptpatch from #117 and #163):Why it's safe
h3-js embeds memory init as a base64 data URI, so
scriptDirectoryfalling back to""works fine — it's never actually used to resolve file paths in bundled deployments.Testing
out/libh3.js__dirnameas beforeFixes #216