-
Notifications
You must be signed in to change notification settings - Fork 140
Bump h3lib to v4.4.1 and add new functions/errors #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8b9d0a6
bump h3lib to v4.4.0
ajfriend 8fee5a5
bump h3lib to v4.4.1
ajfriend 352c955
tests pass with new version
ajfriend 364d03d
add new error codes and some helper functions around error codes
ajfriend 988e4df
jupyter-book<2
ajfriend ed70615
is_valid_index
ajfriend 6ed3079
tests for is_valid_index and get_index_digit
ajfriend 6b267aa
linting
ajfriend 2c58e30
good set of tests
ajfriend 5f8fc99
lint
ajfriend 7ec82e4
thank you, coverage tests for tests!
ajfriend c9e42a0
int api test
ajfriend e7fb9cc
function docstrings
ajfriend dbf4c93
maybe not
ajfriend ec88fe6
changelog. don't expose error code helper functions (yet)
ajfriend f598ae9
ticks
ajfriend 77d3c59
don't even mention 'em
ajfriend d0c0b35
`list` rather than `tuple`, since users are likely to mutate result
ajfriend db03259
remove justfile
ajfriend 260875c
failing tests
ajfriend 1e1749d
tests should be passing
ajfriend e8c7209
more tests
ajfriend d2ae40d
swap docs order
ajfriend File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ h3c/ | |
| .cache/ | ||
| h3/out/ | ||
| .ruff_cache/ | ||
| _build/ | ||
|
|
||
| # Generated C code from Cython test | ||
| tests/**/*.c | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| from .h3lib cimport H3Error | ||
|
|
||
| cpdef error_code_to_exception(H3Error err) | ||
| cdef check_for_error(H3Error err) | ||
| cdef check_for_error_msg(H3Error err, str msg) | ||
| cpdef H3Error get_H3_ERROR_END() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.