Support to cleanup disk cache when enabled#816
Merged
kashishmittal55 merged 3 commits intouber:masterfrom Oct 31, 2025
Merged
Conversation
e911ad6 to
3c34ad5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
+ Coverage 86.29% 86.43% +0.13%
==========================================
Files 84 84
Lines 5123 5144 +21
Branches 804 808 +4
==========================================
+ Hits 4421 4446 +25
+ Misses 560 557 -3
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arushi297
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a helper method to cleanup the local disk cache such that teardown can be handled correctly
Also do this automatically when the context exit occur.
This change will also enable the cleanup=True for local disk cache as that will be the right thing to do most of the times.