Skip to content

Comments

Support to cleanup disk cache when enabled#816

Merged
kashishmittal55 merged 3 commits intouber:masterfrom
kashishmittal55:kashish/cache-cleanup
Oct 31, 2025
Merged

Support to cleanup disk cache when enabled#816
kashishmittal55 merged 3 commits intouber:masterfrom
kashishmittal55:kashish/cache-cleanup

Conversation

@kashishmittal55
Copy link
Collaborator

Add a helper method to cleanup the local disk cache such that teardown can be handled correctly
Also do this automatically when the context exit occur.

This change will also enable the cleanup=True for local disk cache as that will be the right thing to do most of the times.

@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (64cc551) to head (6a864f3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   86.29%   86.43%   +0.13%     
==========================================
  Files          84       84              
  Lines        5123     5144      +21     
  Branches      804      808       +4     
==========================================
+ Hits         4421     4446      +25     
+ Misses        560      557       -3     
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kashishmittal55 kashishmittal55 merged commit b6fbf92 into uber:master Oct 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants