Reshuffle the data after reading from cache if shuffle_rows is true#817
Merged
kashishmittal55 merged 12 commits intouber:masterfrom Dec 16, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
==========================================
+ Coverage 86.39% 86.44% +0.05%
==========================================
Files 84 84
Lines 5144 5158 +14
Branches 808 813 +5
==========================================
+ Hits 4444 4459 +15
+ Misses 558 557 -1
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@kashishmittal55 will the current reproducibility/randomness behavior remain intact with this change? |
Collaborator
Author
Yes correct, it should not affect reproducibility since we will use the same random variable for different training runs. |
arushi297
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If shuffle_rows is true, we do want to shuffle the rows after reading it from cache.
In order to do so, once we read the data, we can reshuffle it. This means, the first time when we are warming up the cache, we will be doing double shuffling.