Conversation
yuxincs
approved these changes
Jul 23, 2025
| end_point: crate::models::matches::Point { row: 0, column: 0 }, | ||
| }, | ||
| text: String::new(), | ||
| node_type: "empty".to_string(), |
Contributor
There was a problem hiding this comment.
Perhaps make this more verbose like <empty-node-type-that-should-never-be-matched>?
empty feels too generic and if we see this when debugging we might think it's a valid node type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new constraint type to the concrete syntax, letting users restrict the types of nodes they match against. This should lead to significant performance improvements at match time.
rootis a special keyword for referring to the entire match, so we can constrain not just capture nodes but the full match itself