Conversation
dvmarcilio
approved these changes
Oct 3, 2025
danieltrt
added a commit
that referenced
this pull request
Oct 6, 2025
The previous [bug fix](#778) was partial. It would work for single application of rules, but not until fix point because I forgot to add the edit to the queue. I've modified the test to reflect the correct behavior and fixed the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There is a bug in piranha core that prevents parent rules from being match only. Parent scope is forcibly applying edits without checking whether the rule is match only. This PR fixes that
Test plan:
I added a test that fails without the fix to illustrate the problem, as well as an E2E test