Added coursier installation support for mac based environments #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuklahy
force-pushed
the
mac-support
branch
from
5d9ed1a to
9ed397d
Compare
shuklahy
changed the title
mnoah1
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenJDK java does not appear on mac based system https://get-coursier.io/docs/cli-java#managed-jvms in managed jvm.
Also the installation URL are different for Mac https://get-coursier.io/docs/cli-installation#native-launcher
Here depending on the OS architecture we decide which coursier url and java version to pick.
For test we use
proxyquireas dependency to mock os environment.Updated yarn lock file and changed the rule prefixes from
node/ton/to match the current naming convention of the eslint-plugin-n package (formerly eslint-plugin-node)Test:
Tested the installation on mac and linux environments
Also checked test runs there