Skip to content

Conversation

@mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Feb 28, 2025

When resolving test symbols in a document, it's possible that there are situations where the call to get document symbols will return undefined (mainly if language server is still activating). This was resulting in an uncaught exception that causes the loading to appear "stuck" on the UI. This adds correct handling if this result is undefined.

@mnoah1 mnoah1 marked this pull request as ready for review February 28, 2025 20:09
@mnoah1 mnoah1 merged commit 5dbff19 into uber:main Feb 28, 2025
4 checks passed
@mnoah1 mnoah1 deleted the undefined-symbols branch February 28, 2025 20:38
@shuklahy shuklahy mentioned this pull request Mar 6, 2025
shuklahy added a commit that referenced this pull request Mar 6, 2025
## What's Changed
*  #41 by @mnoah1 
* #40  by @mnoah1 
* #39 by @mnoah1 
*  #38 by @shuklahy
*  #36 by @mnoah1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants