-
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/scrub interpreter #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the plugins to do the right thing with error conditions.
For better or worse.
Minor other tweaks.
That's about it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #41 +/- ##
===========================================
- Coverage 69.91% 63.56% -6.36%
===========================================
Files 86 53 -33
Lines 24915 20538 -4377
===========================================
- Hits 17420 13054 -4366
+ Misses 7495 7484 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The counter stuff was messed up because Postgres cares about the type you bind.
There is a fix for the sqlx plugin that specifies the type of
the thing being bound.
There is a fix for blessing tests. I needed to disable all the
noise that the extruder and compiler make.
There is an async block addition too. Now you can create async
blocks and await them:
```rust
fn main() {
let x = async {
let y = 1;
y
};
let z = x.await;
// This will print 1
println!("{}", z);
}
```
`
Ran into this thing with FFi lists not having a type. Sorted it out by giving it the option of a type. Fixed the into value trait impl that's used after the invoke_func call to use the type from the ffi list and not the thing we pass in, which is a result.
Prior to this External Implementation blocks were output with no body. Now this fix is sort of silly because I need to make EIs work. But in addition if there is a block with no statements, we will now also throw an error.
I'm on vacation. I worked on some stuff.
Some Cargo updating and some minor changes to the VM.
The `keys()` method used to return the keys in insertion order, but now returns them in an arbitrary order. This messed up my shit. Now it's fixed.
I added a threadpool to the VM for running lambdas. I cleaned up some of the code handling requests in the http plugin.
Check all keys before using them.
I haven't been working on dwarf because of Woog. I'm just getting back into it and I really don't know all that's been done. Recently I fixed importing pre-extruded files. I also fixed a bunch of bugs related to using the new backend. I guess before there was some aliasing going on.
If you did something like this: ```rust let x = 10; let x = "foo"; ``` Then sometimes x is in int and sometimes it's a string. That was then. Nwo it always works.
Fixed a bug where we'd find a type in the store but it wasn't being added to the context's types and thus was being marked as not found. Updated outdated crates. Snafu changed it's interface a bit and it no longer requires the `Location` import. That touched a lot of files. Fixed an FFI bug with the plugins where a `Result` was being typed as `Result` and not `std::result::Result`.
Ended up using an ordered hash map for the store. Plugins are building. Tests are passing. This should be g2g.
- Update Rust to 1.84 - Add more verbose output to xtask plugin output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.