Skip to content

Conversation

@uberFoo
Copy link
Owner

@uberFoo uberFoo commented May 29, 2024

No description provided.

@codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 41.83381% with 812 lines in your changes missing coverage. Please review.

Project coverage is 63.56%. Comparing base (1e7167e) to head (3a50000).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/dwarf/extruder.rs 48.21% 246 Missing ⚠️
src/chacha/ffi_value.rs 13.74% 182 Missing ⚠️
src/dwarf/items/strukt.rs 17.39% 76 Missing ⚠️
src/bubba/vm.rs 59.25% 66 Missing ⚠️
src/bin/main.rs 0.00% 46 Missing ⚠️
src/bubba/value.rs 31.48% 37 Missing ⚠️
src/bubba/compiler/expression/block.rs 32.07% 36 Missing ⚠️
src/dwarf/error.rs 0.00% 26 Missing ⚠️
src/bubba/compiler.rs 14.28% 24 Missing ⚠️
src/dwarf/items/func.rs 41.37% 17 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    69.91%   63.56%   -6.36%     
===========================================
  Files           86       53      -33     
  Lines        24915    20538    -4377     
===========================================
- Hits         17420    13054    -4366     
+ Misses        7495     7484      -11     
Flag Coverage Δ
unittests 63.56% <41.83%> (-6.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

uberFoo added 23 commits June 1, 2024 06:26
The counter stuff was messed up because Postgres
cares about the type you bind.
There is a fix for the sqlx plugin that specifies the type of
the thing being bound.

There is a fix for blessing tests. I needed to disable all the
noise that the extruder and compiler make.

There is an async block addition too. Now you can create async
blocks and await them:

```rust
fn main() {
    let x = async {
        let y = 1;
        y
    };
    let z = x.await;
    // This will print 1
    println!("{}", z);
}
```
`
Most especially for the async block.
Ran into this thing with FFi lists not having a type.
Sorted it out by giving it the option of a type.
Fixed the into value trait impl that's used after the
invoke_func call to use the type from the ffi list and
not the thing we pass in, which is a result.
Prior to this External Implementation blocks were output with no body.
Now this fix is sort of silly because I need to make EIs work.

But in addition if there is a block with no statements, we will now also
throw an error.
I'm on vacation. I worked on some stuff.
Some Cargo updating and some minor changes to the VM.
The `keys()` method used to return the keys in insertion order, but now
returns them in an arbitrary order. This messed up my shit. Now it's
fixed.
I added a threadpool to the VM for running lambdas.

I cleaned up some of the code handling requests in the http plugin.
Check all keys before using them.
I haven't been working on dwarf because of Woog. I'm just getting
back into it and I really don't know all that's been done.

Recently I fixed importing pre-extruded files. I also fixed a bunch
of bugs related to using the new backend. I guess before there
was some aliasing going on.
If you did something like this:
```rust
let x = 10;
let x = "foo";
```
Then sometimes x is in int and sometimes it's a string.

That was then. Nwo it always works.
Fixed a bug where we'd find a type in the store but it wasn't being
added to the context's types and thus was being marked as not found.

Updated outdated crates. Snafu changed it's interface a bit and it
no longer requires the `Location` import. That touched a lot of files.

Fixed an FFI bug with the plugins where a `Result` was being typed
as `Result` and not `std::result::Result`.
Ended up using an ordered hash map for the store.

Plugins are building. Tests are passing. This should be g2g.
- Update Rust to 1.84
- Add more verbose output to xtask plugin output
I updated the install task to create the extruded directory in addition
to the compiled directory.

Refactored the DWARF_HOME calculation to main instead of having it in
each of the install and plugin tasks.
@uberFoo uberFoo marked this pull request as ready for review January 13, 2025 14:29
@uberFoo uberFoo merged commit 3982f61 into develop Jan 13, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants