Skip to content

Fix for jsk_common and jsk_3rdparty, and maybe other catkin_virtualenv packages#37

Closed
k-okada wants to merge 5 commits intoubi-agni:mainfrom
k-okada:fix-for-jsk
Closed

Fix for jsk_common and jsk_3rdparty, and maybe other catkin_virtualenv packages#37
k-okada wants to merge 5 commits intoubi-agni:mainfrom
k-okada:fix-for-jsk

Conversation

@k-okada
Copy link
Contributor

@k-okada k-okada commented Apr 6, 2025

@rhaschke
sorry for late, to work with jsk package,

  1. we need to use patched veresion of bloom, --skip-pip and --skip-test-dependcies, Of course , theoretically, we could remove those depends from our package.xml but we have been using our --skip-pip for releasing debs and also before bloom 0.11.0, the test_depends is not included in debian dependenceis, that's why we use 0.10.7 at k-okada/ros-deb-builder-action@df26dd2#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R5-R11
  2. jsk packges uses a lot of catkin_virtualenv, and we need https://github.com/v4hn/ros-deb-builder-action/pull/10/files to run within recent version of sbuild

I have checked this works well on jsk_common/noble at https://github.com/k-okada/ros-builder-action/actions/runs/14280932656 and currently testing for jsk_3rdparty at https://github.com/k-okada/ros-builder-action/actions/runs/14293996419

c.f. #32

@k-okada
Copy link
Contributor Author

k-okada commented Apr 7, 2025

jsk-3rdparty was also successful. -> https://github.com/k-okada/ros-builder-action/actions/runs/14293996419/job/40087026889

I'll merge following patches once they passed CI
jsk_common : jsk-ros-pkg/jsk_common#1816
jsk_3rdparty : jsk-ros-pkg/jsk_3rdparty#521

@k-okada
Copy link
Contributor Author

k-okada commented Apr 8, 2025

@rhaschke @mqcmd196

jsk_recognition and jsk_visualization passed without any modification !!! 🎉
https://github.com/k-okada/ros-builder-action/actions/runs/14321265227

@mqcmd196
Copy link
Contributor

mqcmd196 commented Apr 8, 2025

I really appreciate your work!!! Our new comers would be happy!!!

@mqcmd196 mqcmd196 mentioned this pull request Apr 8, 2025
@rhaschke rhaschke mentioned this pull request Apr 8, 2025
@rhaschke
Copy link
Member

Merged via #42

@rhaschke rhaschke closed this Apr 22, 2025
@k-okada k-okada deleted the fix-for-jsk branch April 22, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants