Fix for jsk_common and jsk_3rdparty, and maybe other catkin_virtualenv packages#37
Closed
k-okada wants to merge 5 commits intoubi-agni:mainfrom
Closed
Fix for jsk_common and jsk_3rdparty, and maybe other catkin_virtualenv packages#37k-okada wants to merge 5 commits intoubi-agni:mainfrom
k-okada wants to merge 5 commits intoubi-agni:mainfrom
Conversation
Contributor
Author
|
jsk-3rdparty was also successful. -> https://github.com/k-okada/ros-builder-action/actions/runs/14293996419/job/40087026889 I'll merge following patches once they passed CI |
Contributor
Author
|
jsk_recognition and jsk_visualization passed without any modification !!! 🎉 |
Contributor
|
I really appreciate your work!!! Our new comers would be happy!!! |
Merged
Member
|
Merged via #42 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rhaschke
sorry for late, to work with jsk package,
--skip-pipand--skip-test-dependcies, Of course , theoretically, we could remove those depends from our package.xml but we have been using our--skip-pipfor releasing debs and also before bloom 0.11.0, the test_depends is not included in debian dependenceis, that's why we use 0.10.7 at k-okada/ros-deb-builder-action@df26dd2#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823R5-R11I have checked this works well on jsk_common/noble at https://github.com/k-okada/ros-builder-action/actions/runs/14280932656 and currently testing for jsk_3rdparty at https://github.com/k-okada/ros-builder-action/actions/runs/14293996419
c.f. #32