use catkin-supported BehaviorTree.CPP#87
Merged
rhaschke merged 1 commit intoubi-agni:mainfrom Sep 16, 2025
Merged
Conversation
The previous version was accidentally picked in befd342 and the commit statement there states 4.7.1 removed catkin-support. But it was actually commit BehaviorTree/BehaviorTree.CPP@ac26aea before 4.7.0. 3a00bc307e511611203fdd0acdaadbad8d68a772 is the last commit before that one.
v4hn
added a commit
to v4hn/ros-o-builder
that referenced
this pull request
Sep 15, 2025
The previous commit was copied over from ubi-agni/ros-builder-action. See ubi-agni/ros-builder-action#87
Member
|
Did you observe specific issues building version 3c62813, which I picked before? I think, this is the last one building successfully for ROS One. The older one, you picked here, works as well - but is older. |
Contributor
Author
|
The reason I noticed is because the package.xml depends on ament_cmake which is not available on my builder and I had I guess your environment provides ament_cmake which is why it built for you, but the commit that dropped catkin support also removed functional code, notably ROS package lookup for plugins and setting the package up as a catkin-package, which are then missing in your package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous version was accidentally picked in befd342 and the commit statement there states 4.7.1 removed catkin-support. But it was actually commit BehaviorTree/BehaviorTree.CPP@ac26aea before 4.7.0 that removed the support.
3a00bc307e511611203fdd0acdaadbad8d68a772 is the last commit before that one.