fix: address embeddings cache review threads

[0x4007]

Fixes the remaining unresolved review threads left on PR #10.

• Retry cache writes after any eviction progress (including stale index key deletions).
• Clarify quota retry semantics by renaming the constant (MAX_RETRIES) while keeping behavior the same.
• Remove an unused wroteNew counter.
• Tighten quota-error detection to avoid treating generic "limit exceeded" errors as quota.

Validation:

• deno task fmt
• deno task lint
• deno task test

[github-actions]

09 Feb 17:50

2ad4f9c fix: address embeddings cache review threads

Show 1 previous deployments

09 Feb 17:50

2ad4f9c fix: address embeddings cache review threads

[Copilot]

Pull request overview

This PR resolves remaining review threads from PR #10 by refining the embeddings KV cache’s quota-driven eviction/retry behavior and removing unused bookkeeping, keeping the cache best-effort while reducing false-positive “quota” classifications.

Changes:

• Retry cache writes after any eviction progress (including deleting stale index keys), not only after evicting embeddings.
• Rename the retry constant to clarify semantics (EMBEDDINGS_CACHE_QUOTA_MAX_RETRIES) without changing behavior.
• Tighten quota-error detection by removing the generic "limit exceeded" heuristic and remove an unused wroteNew counter.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

📝 Walkthrough

Walkthrough

PR modifies embeddings cache eviction logic in src/openai.ts. Renames constant EMBEDDINGS_CACHE_QUOTA_RETRY_ATTEMPTS to EMBEDDINGS_CACHE_QUOTA_MAX_RETRIES. Updates eviction termination condition to require both evicted_embeddings and deleted_stale_index_keys to be zero before stopping retries (previously only checked evicted_embeddings). Removes unused wroteNew variable from embeddings write path and adds clarifying comments.

Possibly related PRs

• fix: keep embeddings cache_count tied to evicted entries #9: Modifies cache eviction logic in same file, adjusting guards for cache_count decrement and termination behavior.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objective: addressing unresolved review threads from a previous PR regarding embeddings cache fixes.
Description check	✅ Passed	The description clearly relates to the changeset, detailing the specific fixes made: constant rename, eviction logic adjustment, unused variable removal, and quota-error detection tightening.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/embeddings-cache-review-comments

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}