This repository was archived by the owner on Sep 19, 2024. It is now read-only.
build: making ignoring of children dynamic#825
Open
GaryThisSidee wants to merge 11 commits intoubiquity:developmentfrom
Open
build: making ignoring of children dynamic#825GaryThisSidee wants to merge 11 commits intoubiquity:developmentfrom
GaryThisSidee wants to merge 11 commits intoubiquity:developmentfrom
Conversation
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
whilefoo
suggested changes
Sep 25, 2023
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
Contributor
wannacfuture
left a comment
wannacfuture
left a comment
There was a problem hiding this comment.
We can remove itemsToExclude prop from parseComments function and just get that information from the config in that function.
whilefoo
suggested changes
Sep 26, 2023
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
…rom the config directly
whilefoo
suggested changes
Oct 2, 2023
whilefoo
suggested changes
Oct 5, 2023
Co-authored-by: whilefoo <139262667+whilefoo@users.noreply.github.com>
whilefoo
approved these changes
Oct 5, 2023
Author
|
@wannacfuture can u take a look |
wannacfuture
approved these changes
Oct 9, 2023
Author
|
@0xcodercrane can u take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #772