Merged
Conversation
Contributor
|
Caution No labels are set. |
whilefoo
reviewed
Sep 17, 2025
whilefoo
left a comment
whilefoo
left a comment
There was a problem hiding this comment.
shouldn't development script be also fixed?
Contributor
Author
Fixed in c09cf21 |
whilefoo
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1001
Depends on #1003
This PR fixes staking migration which was broken after changes in #999
How to QA production staking: https://gist.github.com/ryzhak/78ffabebeef6540b4e085c132df1d6a8
Note, here we set
block.number + 10because foundry works pretty weird (at least the latest v1.3.5.). It seems it cachesblock.numberat the beginning of the script and later (if there was a new block mined) here doesn't fetch the latestblock.numberbut uses the cached one. Hence the errorError: reverted with: Can't start in the pastoccurs. Setting it toblock.number + 10helps both for QA and production deploy in case a new block is mined somewhere in the middle of migration execution. Setting staking start time toblock.number + 10simply delays staking start time for ~2 mins.