Skip to content

ci: fix Diamond Storage Check artifact upload#1007

Open
energypantry wants to merge 2 commits intoubiquity:developmentfrom
energypantry:fix/992-diamond-storage-artifact-name
Open

ci: fix Diamond Storage Check artifact upload#1007
energypantry wants to merge 2 commits intoubiquity:developmentfrom
energypantry:fix/992-diamond-storage-artifact-name

Conversation

@energypantry
Copy link

@energypantry energypantry commented Feb 7, 2026

Fixes #992.

The Diamond Storage Check workflow was failing with an invalid artifact name error (artifact name generated from branch + contract path).

This PR switches the workflow to a patched foundry-storage-check action revision that:

  • Sanitizes + shortens artifact names deterministically (branch slug + hash)
  • Avoids failing PRs when the base branch report artifact is not present yet (warn + skip compare)

Action ref used: energypantry/foundry-storage-check@fb95d25056453a7d61643f411ab2b3acaea33a39.

If you prefer keeping the action under the ubiquity org, I can open the corresponding upstream PR (same commits) to ubiquity/foundry-storage-check and then we can repin to that ref.

@coderabbitai
Copy link

coderabbitai bot commented Feb 7, 2026

Warning

Rate limit exceeded

@energypantry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@energypantry
Copy link
Author

All checks are green now. @rndquu when you have a moment, could you please review/merge this fix for the Diamond Storage Check artifact-name failure? Thanks.

@energypantry
Copy link
Author

Quick follow-up: all checks are green on this PR. When you have a moment, could you please review/merge the CI fix so Diamond Storage Check stops failing on PRs? Thanks. cc @rndquu

@energypantry
Copy link
Author

@rndquu Could you take a quick Codeowner look on this PR when you have a moment?

All checks are green and it's ready to merge once the requested review is in. Happy to tweak anything you spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: fix failing Diamond Storage Check

1 participant