Use NeoSmart.AsyncLock in NGitLab.Mock.Clients.ClientContext #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-z
changed the title
After a few attempts at fixing the SemaphoreSlim-based ClientContext, use something that is said to be an async/await-friendly replacement for the `lock` implementation. This means it supports reentrancy.
louis-z
force-pushed
the
use-neosmart-asynclock-in-ngitlab-mock-clients-cl
branch
from
c0d06a6 to
73492d6
Compare
louis-z
deleted the
use-neosmart-asynclock-in-ngitlab-mock-clients-cl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few attempts at fixing the
SemaphoreSlim-basedClientContext, which caused problems because it did not support reentrancy, use something that does:NeoSmart.AsyncLock. It is said to be anasync/await-friendly replacement for thelockimplementation.See https://neosmart.net/blog/asynclock-an-asyncawait-friendly-locking-library-for-c-and-net/