Draft
Conversation
3f015a2 to
f1b8ff7
Compare
ubitux
requested changes
Oct 7, 2023
Owner
ubitux
left a comment
There was a problem hiding this comment.
Nice, thanks.
It seems you didn't break X11, works fine here, so feel free to remove the draft.
Owner
Does that happen for viewable windows?
It's supposed to be, I guess. I will make it obvious in the combo box which window is visible or not (italic for non-visible, or maybe bold for visible) Ah, also, can you update the |
89ef84c to
13a132d
Compare
13a132d to
83c86af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Listing windows seems to be working correctly. However :
xcffib.xproto.MapState.Viewablemeans. If it is equivalent to https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-iswindowvisible, I'll have to change_enum_windows_cb. For now it always returns(window_name, True)I'l leave this PR a draft for now.