-
-
Notifications
You must be signed in to change notification settings - Fork 56
chore: remove fw-fanctrl package for now #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the broken fw-fanctrl package installation from the base package build script. The package, which was being installed from the ublue-os/staging COPR repository, is currently broken and causing installation failures.
Changes:
- Removed
fw-fanctrlpackage installation from the COPR packages section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think we should investigate first what hardware would be affected by this, fix the package if possible. Do we even still need it at all? The package on my Intel Framework 13 13th Gen still does something and seems to not be completely broken. |
This is mainly used for custom fancurves. When removed it just uses whatever are the defaults (in BIOS i guess). There is config in /etc where you can set the custom curves and modify them and create specific profiles. In general this isn't really needed for "anything". It was just a addition in that sense, not really sure how much use this actually is getting. But if the package can easily be fixed then its propably fine to keep it. |
|
related upstream PR: |
|
if this isn't magically resolved by then, then I say we remove it with F44. If it isn't breaking our builds before then anyway |
Currently broken package and won't install.