Skip to content

Conversation

@inffy
Copy link
Member

@inffy inffy commented Jan 26, 2026

Currently broken package and won't install.

Copilot AI review requested due to automatic review settings January 26, 2026 07:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the broken fw-fanctrl package installation from the base package build script. The package, which was being installed from the ublue-os/staging COPR repository, is currently broken and causing installation failures.

Changes:

  • Removed fw-fanctrl package installation from the COPR packages section

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@renner0e
Copy link
Member

I think we should investigate first what hardware would be affected by this, fix the package if possible. Do we even still need it at all?

The package on my Intel Framework 13 13th Gen still does something and seems to not be completely broken.

@inffy
Copy link
Member Author

inffy commented Jan 26, 2026

I think we should investigate first what hardware would be affected by this, fix the package if possible. Do we even still need it at all?

The package on my Intel Framework 13 13th Gen still does something and seems to not be completely broken.

This is mainly used for custom fancurves. When removed it just uses whatever are the defaults (in BIOS i guess). There is config in /etc where you can set the custom curves and modify them and create specific profiles.

In general this isn't really needed for "anything". It was just a addition in that sense, not really sure how much use this actually is getting. But if the package can easily be fixed then its propably fine to keep it.

@renner0e
Copy link
Member

related upstream PR:

TamtamHero/fw-fanctrl#138

@inffy inffy marked this pull request as draft January 26, 2026 09:09
@renner0e
Copy link
Member

renner0e commented Feb 2, 2026

if this isn't magically resolved by then, then I say we remove it with F44. If it isn't breaking our builds before then anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants