fix(ci): use kernel version in tag to fix builds#349
Merged
Conversation
This will ensure that the most specific version of the akmods tag is used so ucore builds will pull the correct nvidia akmod image to match the kernel from akmods-zfs even if it is pinned and there are newer versions of the akmod-nvidia images.
There was a problem hiding this comment.
Pull request overview
This PR fixes CI builds by including the kernel version in akmod image tags to ensure exact version matching between akmods-zfs and akmods-nvidia images.
Changes:
- Added KERNEL_VERSION environment variable support to the build system
- Updated all akmod image references to include the kernel version in their tags
- Modified the Justfile to construct akmod tags with kernel version when available
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ucore/Justfile | Added KERNEL_VERSION variable and logic to include it in AKMODS_TAG when building containerfiles |
| .github/workflows/reusable-build.yml | Updated podman pull/inspect commands to use kernel-specific akmod image tags and pass KERNEL_VERSION to just |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m2Giles
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that the most specific version of the akmods tag is used so ucore builds will pull the correct nvidia akmod image to match the kernel from akmods-zfs even if it is pinned and there are newer versions of the akmod-nvidia images.