Improve accented icons rendering#4406
Merged
3v1n0 merged 13 commits intoubuntu:masterfrom Mar 14, 2026
Merged
Conversation
Contributor
3v1n0
commented
Mar 14, 2026
3v1n0
commented
- Avoid duplicating icons for rendering the default variant
- Renders icons for dark icon theme when needed
- Improve contrast for icons rendering
…e it" This reverts commit b8f6686.
We were actually using the inverted logic, so that the accent was darker on dark background and lighter on light backgrounds
They can be useful for dark assets
…pps icons These have less contrast issues, because they are normally just used as big icons and in a dark (for yaru) background, so we can just use the accent as it is
We excluded default accent rendering since we wanted default-accent specific icons, but now this need is quite reduced. But in any case this should be a special case, so if a specific flavor source icon is provided, then we use it for rendering, otherwise we use the accented version for being re-colored
We can now just rely on the colorization to generate them all
We tune the gradients though, now that we have more accented color options we can just rely on contrast-optimized values
At this point the difference is not worth keeping the diff
…grounds The icons are quite light with an anccent on top, make them more contrast-friendly
… icons These icons are normally shown on top of white or dark backgrounds so it makes sense to have them rendered to be more visible on those
We are currently not using the *-dark themes variants much, but it exists for a while, so we can now generate icons for them. If an icon is now part of icons/src/fullcolor/accented-full then the icon will be rendered for both flavors. Of course this makes sense only if the icons are using dark-specific colors, otherwise it's just a duplication. We do not check for duplicates yet, but it would make sense in future
Contributor
Author
|
Let's merge so hopefully CI will do the job of re-generating everything... Hoping it does not fail 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.