Skip to content

fix(discoveryLoadingBar): Added react state allBatchesAreReady to tra…#1778

Merged
paulineribeyre merged 3 commits intomasterfrom
fix/discoveryLoadingBar
Mar 13, 2026
Merged

fix(discoveryLoadingBar): Added react state allBatchesAreReady to tra…#1778
paulineribeyre merged 3 commits intomasterfrom
fix/discoveryLoadingBar

Conversation

@jarvisraymond-uchicago
Copy link
Copy Markdown
Contributor

@jarvisraymond-uchicago jarvisraymond-uchicago commented Mar 13, 2026

Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/GFF-546

After Update
MIDRC
output
HEAL
output

Bug Fixes

  • Fixes scrollbar hang edge case on Discovery page

…ck when all batches are ready instead of using a const
@jarvisraymond-uchicago jarvisraymond-uchicago marked this pull request as draft March 13, 2026 14:20
@jarvisraymond-uchicago jarvisraymond-uchicago marked this pull request as ready for review March 13, 2026 14:50
craigrbarnes
craigrbarnes previously approved these changes Mar 13, 2026
Copy link
Copy Markdown
Contributor

@craigrbarnes craigrbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look file to me. Keeping the batch status in state is a good solution.

@github-actions
Copy link
Copy Markdown

Test summary after running integration tests

filepath passed failed skipped SUBTOTAL
tests/test_requestor.py 5 0 0 5
tests/test_user_token.py 3 0 0 3
tests/test_audit_service.py 1 0 0 1
tests/test_data_upload.py 2 0 0 2
tests/test_login_page.py 2 0 0 2
tests/test_dbgap.py 1 0 0 1
tests/test_discoverypage.py 1 0 0 1
tests/test_dicom_viewer.py 1 0 0 1
tests/test_pfb_export.py 1 0 0 1
tests/test_ras_authn.py 0 0 3 3
tests/test_gen3ff_landing_page.py 0 0 2 2
tests/test_register_user.py 0 2 0 2
tests/test_workspace.py 0 1 0 1
tests/test_homepage.py 0 1 0 1
tests/test_graph_submit_and_query.py 0 1 0 1
TOTAL 17 5 5 27

Test summary after rerunning failed integration tests

filepath passed SUBTOTAL
tests/test_register_user.py 2 2
tests/test_homepage.py 1 1
tests/test_graph_submit_and_query.py 1 1
tests/test_workspace.py 1 1
TOTAL 5 5

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

@paulineribeyre paulineribeyre merged commit 5b70d04 into master Mar 13, 2026
9 checks passed
@paulineribeyre paulineribeyre deleted the fix/discoveryLoadingBar branch March 13, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants