Add /user-bucket/objects delete endpoint; return 400 for invalid TES requests#101
Merged
paulineribeyre merged 9 commits intomasterfrom Feb 11, 2026
Merged
Add /user-bucket/objects delete endpoint; return 400 for invalid TES requests#101paulineribeyre merged 9 commits intomasterfrom
/user-bucket/objects delete endpoint; return 400 for invalid TES requests#101paulineribeyre merged 9 commits intomasterfrom
Conversation
…for invalid TES requests
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 21914996984Details
💛 - Coveralls |
Collaborator
paulineribeyre
left a comment
paulineribeyre
left a comment
There was a problem hiding this comment.
Nice
I think you need to update the branch
gen3workflow/routes/ga4gh_tes.py
Outdated
Comment on lines
+99
to
+102
| raise HTTPException( | ||
| status_code=HTTP_400_BAD_REQUEST, | ||
| detail=f"Invalid JSON in request body: {e.msg}", | ||
| ) |
Collaborator
There was a problem hiding this comment.
we could move the try/catch to get_request_body around json.loads(body)
Comment on lines
+67
to
+70
| "details": ( | ||
| "Amazon S3 processes bucket deletion asynchronously. " | ||
| "The bucket may remain visible for a short period until " | ||
| "deletion fully propagates across AWS." |
Contributor
Author
|
This PR relies on gen3-code-vigil branch : Or wait for the gen3-code-vigil#462 to merge before merging this PR. |
paulineribeyre
previously approved these changes
Feb 11, 2026
…o chore/delete_bucket_false
paulineribeyre
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: MIDRC-1180
New Features
DELETE /user-bucket/objectsendpointBreaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes