Conversation
thanh-nguyen-dang
force-pushed
the
feat/boolean
branch
from
4ae00f0 to
d17a012
Compare
thanh-nguyen-dang
force-pushed
the
feat/boolean
branch
from
d17a012 to
ef62c2c
Compare
mfshao
left a comment
mfshao
left a comment
There was a problem hiding this comment.
See my comment
I would say I'd still perfer to make Tube be backward-compatible, especially considering the new Tube release just bumps up its patch version, rather than making a breaking change into Guppy and/or Portal
| byte: 'Int', | ||
| double: 'Float', | ||
| float: 'Float', | ||
| boolean: 'Boolean', |
There was a problem hiding this comment.
how about just treat boolean as string for gql types?
either way, we will need to test before merging, especially to test use new Tube do ETL, and then see if Guppy/Portal can work (data explorer/study viewer)
One concern I have is that in data explorer we need to verify if we put a boolean field in filters, when selecting the filter, does it will send a string value back to guppy and causes problems. This can be testing in qa-covid19
There was a problem hiding this comment.
it is tested in qa-niaid @mfshao . And we should use boolean if graphql supports boolean.
There was a problem hiding this comment.
I don't want see it tested in one env for one feature and after merging it breaks another feature in another env. If we know it might potential be dangerous, we need to do more testing and verify things are ok, or fix more before merging. Don't rush to merge into master
|
@thanh-nguyen-dang is this still an issue? can we get someone to test it? |
3 participants
Jira Ticket: PXP-xxxx
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes