Fix WASM compilation and add cross-platform time support#179
Open
Gozala wants to merge 1 commit intoucan-wg:mainfrom
Open
Fix WASM compilation and add cross-platform time support#179Gozala wants to merge 1 commit intoucan-wg:mainfrom
Gozala wants to merge 1 commit intoucan-wg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes WASM compilation errors and adds proper cross-platform time
support using web-time.
Problem
The crate had WASM-specific code using js_sys::Date, wasm_bindgen, and
JsError but:
on this platform
Changes
Add missing WASM dependencies (ucan/Cargo.toml)
Fix cross-platform time support (ucan/src/time/timestamp.rs,
ucan/src/time/error.rs)
Fix WASM Timestamp methods (ucan/src/time/timestamp.rs)
trait bound errors)
Result<Timestamp, OutOfRangeError>