fix: Remove broken e2e/server/pkg symlink#184
Open
tennox wants to merge 1 commit intoucan-wg:mainfrom
Open
Conversation
The symlink pointed to ../../pkg (ucan_wasm/pkg) which is a wasm-pack build artifact that doesn't exist in the repository. This broken symlink causes issues with tools that traverse the directory tree (like ripgrep used by Nix/crane during dependency vendoring). The e2e tests require building the wasm package first anyway, so this symlink should be created as part of the build process, not checked into the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my work of upgrading https://gitlab.com/wovin/deploy/ucan-store-proxy/, I had trouble using this crate with crane and git input (since it's not released yet with UCAN v1.0.0-rc spec code - which would be nice actually)
The symlink pointed to ../../pkg (ucan_wasm/pkg) which is a wasm-pack build artifact that doesn't exist in the repository. This broken symlink causes issues with tools that traverse the directory tree (like ripgrep used by Nix/crane during dependency vendoring).
The e2e tests require building the wasm package first anyway, so this symlink should be created as part of the build process, not checked into the repository. (I think)