Update ICV defaults for RHEL9, fix version_number()

[daniellovell]

The BWRC servers migrated to RHEL9, and with that, our old setup using S-2021.06-SP3-2 for the default ICV version is not functional.

In general, users of RHEL9 should adopt W-2024.09-4 for ICV and V-2023.09-SP2 for ICVWB.

Synopsys now defaults to install these newer ICV versions at the /icvalidator/ directory instead of /icv/, so the ICV_HOME env var should reflect this.

Finally, SynopsysTool.version_number() fails to correctly parse W-2024.09-4:

This change fixes that, and includes regression unit tests to ensure previous versions of ICV can still be successfully parsed

Related PRs / Issues
Related to this PR for hammer-intech22-plugin https://bwrcrepo.eecs.berkeley.edu/intech22/hammer-intech22-plugin/-/merge_requests/72

Type of change:

• Bug fix
• New feature
• Other enhancement

Impact:

• Change to core Hammer
• Change to a Hammer plugin
• Other

Contributor Checklist:

• Did you set master as the base branch?
• Did you state the type-of-change/impact?
• Did you delete any extraneous prints/debugging code?
• (If applicable) Did you add documentation for the feature?
• (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
• (If applicable) Did you add a unit test demonstrating the PR?
• (If applicable) Did you run this through the e2e integration tests?
• (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

[daniellovell]

Should pass all checks if #887 is merged.

[daniellovell]

Note: the fact that this changes the default ICV directory to /icvalidator/ is a somewhat troublesome change. Users who want to use an older version of icv in their icv.version will always need to change the ICV_HOME directory as well. That is to say, this isn't really backward compatible with older default ICV installation directories (/icv/VERSION_NUM). It is forward compatible with Synopsys's new default ICV installation directories (/icvalidator/VERSION_NUM)

[daniellovell]

Tested a few runs of ICV DRC, then used the generated-scripts/view_drc to pop open ICVWB successfully.
Removed the DRAFT tag

Ready to be reviewed

[daniellovell]

Recommend that this is merged together with https://bwrcrepo.eecs.berkeley.edu/intech22/hammer-intech22-plugin/-/merge_requests/72

[elamdf]

LGTM! Maybe someone like @kenhoberkeley can review + merge the intech PR, I don't have write access to that one