finished first draft of resources page and made styling changes #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caz07
commented
Feb 11, 2025
caz07
commented
- created full draft of resources page
- removed a lot of random default styling (e.g. to h1's globally, etc), ruins a lot of the CSS on main page but will fix in next pr
- changed the clickable component css, not sure if it's even necessary at all
|
|
||
| const refArray = ["Studio", "ICPC", "Design", "Cyber", "Teach LA", "W", "AI", "Hack"] | ||
| const sortedTeams = JSON.parse(JSON.stringify(teams)) | ||
| console.log('here1') |
|
|
||
| const ArchiveCommittee = (props) => { | ||
| let {committeeName} = props; | ||
| console.log(committeeName) |
| links: item.links.filter((link) => link.source === committeeName), | ||
| }; | ||
| }); | ||
| console.log(JSON.stringify(filteredList, null, 2)); |
There was a problem hiding this comment.
do we want to keep this log for now and remove later?
snigdha-kansal
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Great progress on this, Charles! I really like the display for the resources page.
I think there's some hydration errors that will need to be resolved.
The styling as you already noted is a bit off. Also, the mobile view is distorted.
Can probably take care of these issues in another pr
Also, will want to add Cloud too
Left a few comments, feel free to merge after addressing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.