Conversation
Member
Author
|
@reginawang99 |
|
Just to confirm, was the intention of the PR to move completely away from Docker? And what could I help with here? I tested on my computer and |
Member
Author
Partially, yes - let me write this down, didn't get the opportunity to do it before. I'll tag you in the issue! |
This was referenced Aug 29, 2021
Closed
Member
Author
|
Just going through my own stale PRs, bump @matthewcn56; what do you want to do about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR (in its current state):
create-react-appviareact-scriptshomepagefield inpackage.jsonAPI_URLto read from theDEVenv var; defaults tohttps://members.uclaacm.com/appif we're not in dev, which currently causes a CORS issue if not deployed to itnode-sasswithsassLatotoOpen SansLocally, it builds and runs; we only run into problems once we hit the backend, as this introduces CORS issues.
To merge this, I think we need to:
yarn buildpasses