Skip to content

Conversation

@smalex-z
Copy link
Contributor

@smalex-z smalex-z commented Dec 2, 2024

Description

GM Data is now parsed through google sheets (link). New JSON sheet is created to store data for past GMs in 'past-gm.json'. Past GMs have the season, date, banner, and slides displayed (and recording if available). Furthermore, minor bugs on the GM page are fixed- some key errors with JSON mapping as well as border on the map is removed.

Fixes issue #737

How Has This Been Tested?

npm run build -> npm start

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Deploy

  • Passes Lint Checks (npm run lint & npm run lint-fix)
  • All Checks have passed
  • Deploy Preview looks good and runs with no errors

@snigdha-kansal
Copy link
Contributor

snigdha-kansal commented Dec 2, 2024

This looks great to me, Alex!
Thanks for working on it 💯

Penguin Nice

I've asked pvp about it. Once we have the summaries for the past GMs, we can go ahead and merge it.
Additionally, we will want to remove the past GM pages once this has been merged to remove unneeded code bloat on the frontend.

@smalex-z
Copy link
Contributor Author

smalex-z commented Mar 4, 2025

Ready to be merged when we add summaries to each of the past GMs in the google sheets

Copy link
Contributor

@yeadamk yeadamk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to update the sheets for past gm descriptions

@smalex-z smalex-z merged commit f07af96 into main Apr 7, 2025
8 checks passed
@smalex-z smalex-z deleted the gm-updates branch April 7, 2025 07:29
@yeadamk yeadamk mentioned this pull request Apr 9, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants