Skip to content

Conversation

@snigdha-kansal
Copy link
Contributor

@snigdha-kansal snigdha-kansal commented Feb 8, 2025

Overview

Deploy Preview: https://deploy-preview-753--jovial-pasteur-581b4a.netlify.app/

Changes

Package Upgrades:

  • next: updated from 14.2.3 to 15.1.6
  • @testing-library/react: updated from 15.0.7 to 16.2.0
  • jest-axe: updated from 7.0.0 to 9.0.0
  • stylelint: updated from 13.13.1 to 16.14.1
  • stylelint-config-recommended: updated from 5.0.0 to 15.0.0
  • stylelint-config-sass-guidelines: updated from 8.0.0 to 12.1.0
  • stylelint-scss: updated from 3.21.0 to 6.11.0
  • sass: updated from 1.58.3 to 1.84.0
  • googleapis: updated from 109.0.1 to 144.0.0

New Dependencies:

  • added @testing-library/dom to make tests pass

Code Refactoring:

  • removed import React from 'react'; from files in accordance with React 17
  • refactored Banner.js and Carousel.js from class components to functional components using React hooks
  • fixed hydration errors by changing <p> to <div>
  • created testimonial-class to ensure cascading styling
  • added dimensions to images in gm.js to ensure correct rendering
  • replaced @import with @use in .scss files for compatibility with latest sass version

Testing

The deploy preview for the website loads each page correctly, with all components rendering as expected. No issues with hydration errors or broken styling.

Possible Changes

  • update eslint and eslint-config-next to their latest versions (this is a breaking change and will require several modifications to current configuration for it to work properly)
  • update react and react-dom to their latest versions once react-accessible-accordion supports them
  • update to using node 22.13.1
  • fix image rendering for carousel

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

@snigdha-kansal snigdha-kansal changed the title Update dependencies chore: update dependencies Feb 8, 2025
@snigdha-kansal snigdha-kansal marked this pull request as ready for review February 9, 2025 06:12
@smalex-z
Copy link
Contributor

smalex-z commented Feb 9, 2025

lgtm, everything seems to render properly (besides the images in the carousel, not impacted by this PR) and no errors within the DevTools menu

@snigdha-kansal snigdha-kansal merged commit 5004b08 into main Feb 9, 2025
8 checks passed
@snigdha-kansal snigdha-kansal deleted the update-dependencies branch February 9, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants