Skip to content

Conversation

@snigdha-kansal
Copy link
Contributor

@snigdha-kansal snigdha-kansal commented Mar 4, 2025

Overview

Deploy Preview: https://deploy-preview-766--jovial-pasteur-581b4a.netlify.app/

Changes

  • Removed duplicate committee links from navigation bar in the mobile view
  • Removed unnecessary passHref={true} from <ActiveLink> elements
  • Refactored menu items to use .map() instead of manually listing links

Testing

  1. Visit the Netlify deploy preview link.
  2. Inspect Element and change the device dimensions to any mobile view.
  3. Click the Hamburger menu in the top right.
  4. Each link should only display once.
Untitled.mov
image

Possible Changes

  • N/A

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

@ArshMalik02 ArshMalik02 self-requested a review March 4, 2025 05:51
Copy link
Contributor

@ArshMalik02 ArshMalik02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@snigdha-kansal snigdha-kansal merged commit 0ac3a30 into main Mar 4, 2025
8 checks passed
@snigdha-kansal snigdha-kansal deleted the fix-mobile-navbar branch March 4, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants