Open
Conversation
- A gasPrice of 0 can't be set with the current version of the libraries - Gas fee needs to be accounted for - Flag the fact that the default account balances are too big for JS to properly compute the balance changes
tigerinus
reviewed
Mar 27, 2022
| @@ -65,12 +65,26 @@ it('lets user2 buy a star and decreases its balance in ether', async() => { | |||
| let balance = web3.utils.toWei(".05", "ether"); | |||
| await instance.createStar('awesome star', starId, {from: user1}); | |||
| await instance.putStarUpForSale(starId, starPrice, {from: user1}); | |||
There was a problem hiding this comment.
You would need to add approve here for later version of solidity.
await instance.approve(user2, starId, {from: user1});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.