Skip to content

[RFC] Set Error State Matcher from Control Model #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RFC] Set Error State Matcher from Control Model #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,17 @@ export const DEFAULT_ERROR_STATE_MATCHER: DynamicErrorMessagesMatcher =
};
```

You can also set an error matcher on a per control basis by assigning it under the `additional` field:
```ts
new DynamicInputModel({
id: "sampleInput",
label: "Sample Input",
additional: {
errorStateMatcher: myCustomErrorMessagesMatcher
}
})
```

Please note here that NG Dynamic Forms always assumes both the control being invalid and error messages being defined on the model
as a fixed precondition.

Expand Down
20 changes: 12 additions & 8 deletions projects/ng-dynamic-forms/core/src/lib/service/dynamic-form-validation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,18 @@ export class DynamicFormValidationService {
control.updateValueAndValidity();
}

showErrorMessages(control: AbstractControl, model: DynamicFormControlModel, hasFocus: boolean): boolean {

const precondition = control.invalid && model.hasErrorMessages;
const matcher = this._DYNAMIC_ERROR_MESSAGES_MATCHER ? this._DYNAMIC_ERROR_MESSAGES_MATCHER(control, model, hasFocus) :
DEFAULT_ERROR_STATE_MATCHER(control, model, hasFocus);

return precondition && matcher;
}
showErrorMessages(control: AbstractControl, model: DynamicFormControlModel, hasFocus: boolean): boolean {
const precondition = control.invalid && model.hasErrorMessages;

const matcher =
model["getAdditional"] !== undefined && model["getAdditional"]("errorStateMatcher")
? model["getAdditional"]("errorStateMatcher")
: this._DYNAMIC_ERROR_MESSAGES_MATCHER
? this._DYNAMIC_ERROR_MESSAGES_MATCHER
: DEFAULT_ERROR_STATE_MATCHER;

return precondition && matcher(control, model, hasFocus);
}

parseErrorMessageConfig(template: string, model: DynamicFormControlModel, error: any = null): string {

Expand Down