Skip to content

Documentation fixes and refactor#1

Open
darrenklein wants to merge 3 commits intoueberauth:masterfrom
darrenklein:master
Open

Documentation fixes and refactor#1
darrenklein wants to merge 3 commits intoueberauth:masterfrom
darrenklein:master

Conversation

@darrenklein
Copy link

Thank you so much for creating this very helpful example repo! While using it to help me in my own project development, I spotted a few small fixes that I think would benefit this project.

  • replaces use Guardian.Token.Jwt.SecretFetcher with @behaviour Guardian.Token.Jwt.SecretFetcher, since the example uses a custom implementation of fetch_signing_secret and fetch_verifying_secret rather than the default implementations use would provide.
  • updates the documentation to match that, including a fix for a reference to :debug_guardian
  • other small refactors and cleanup

Again, many thanks - your example helped me out a lot, I hope these contributions are beneficial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant