Better ux

.travis.yml

@@ -2,7 +2,6 @@ language: php
 sudo: true
 
 php:
-  - 5.6
   - 7.0
   - 7.1
   - 7.2
@@ -13,19 +12,26 @@ env:
   matrix:
     - TEST_SUITE=8.5.x
     - TEST_SUITE=8.6.x
+    - TEST_SUITE=8.7.x
     - TEST_SUITE=PHP_CodeSniffer
 
 # Only run the coding standards check once.
 matrix:
   exclude:
+    - php: 5.6
+      env: TEST_SUITE=8.7.x
+    - php: 7.0
+      env: TEST_SUITE=8.7.x
+    - php: 7.1
+      env: TEST_SUITE=8.7.x
     - php: 5.6
       env: TEST_SUITE=PHP_CodeSniffer
     - php: 7.0
       env: TEST_SUITE=PHP_CodeSniffer
     - php: 7.1
       env: TEST_SUITE=PHP_CodeSniffer
   allow_failures:
-    - env: TEST_SUITE=8.6.x
+    - env: TEST_SUITE=8.7.x
 
 mysql:
   database: og
@@ -44,9 +50,6 @@ before_script:
   # Remember the current directory for later use in the Drupal installation.
   - MODULE_DIR=$(pwd)
 
-  # Install Composer dependencies for OG.
-  - composer install
-
   # Navigate out of module directory to prevent blown stack by recursive module
   # lookup.
   - cd ..

config/install/core.entity_form_display.og_membership.default.default.yml

@@ -18,4 +18,17 @@ content:
       rows: 2
       placeholder: ''
     third_party_settings: {  }
+  roles:
+    type: options_buttons
+    weight: 0
+    settings: {  }
+    third_party_settings: {  }
+  uid:
+    type: og_autocomplete
+    weight: -1
+    settings:
+      match_operator: CONTAINS
+      size: 60
+      placeholder: ''
+    third_party_settings: {  }
 hidden: {  }

config/install/core.entity_view_display.og_membership.default.default.yml

@@ -14,7 +14,21 @@ content:
   og_membership_request:
     label: above
     type: basic_string
-    weight: 0
+    weight: 2
     settings: {  }
     third_party_settings: {  }
+  roles:
+    type: entity_reference_label
+    weight: 1
+    label: above
+    settings:
+      link: false
+    third_party_settings: {  }
+  uid:
+    type: entity_reference_label
+    weight: 0
+    label: above
+    settings:
+      link: true
+    third_party_settings: {  }
 hidden: {  }

config/optional/views.view.og_members_overview.yml

@@ -421,6 +421,57 @@ display:
           entity_type: og_membership
           entity_field: roles
           plugin_id: field
+        operations:
+          id: operations
+          table: og_membership
+          field: operations
+          relationship: none
+          group_type: group
+          admin_label: ''
+          label: 'Operations links'
+          exclude: false
+          alter:
+            alter_text: false
+            text: ''
+            make_link: false
+            path: ''
+            absolute: false
+            external: false
+            replace_spaces: false
+            path_case: none
+            trim_whitespace: false
+            alt: ''
+            rel: ''
+            link_class: ''
+            prefix: ''
+            suffix: ''
+            target: ''
+            nl2br: false
+            max_length: 0
+            word_boundary: true
+            ellipsis: true
+            more_link: false
+            more_link_text: ''
+            more_link_path: ''
+            strip_tags: false
+            trim: false
+            preserve_tags: ''
+            html: false
+          element_type: ''
+          element_class: ''
+          element_label_type: ''
+          element_label_class: ''
+          element_label_colon: true
+          element_wrapper_type: ''
+          element_wrapper_class: ''
+          element_default_classes: true
+          empty: ''
+          hide_empty: false
+          empty_zero: false
+          hide_alter_empty: true
+          destination: true
+          entity_type: og_membership
+          plugin_id: entity_operations
       filters: {  }
       sorts: {  }
       header: {  }

config/schema/og.schema.yml

@@ -193,3 +193,18 @@ condition.plugin.og_group_type:
       type: sequence
       sequence:
         type: string
+
+# Copied and adapted from core.entity.schema.yml
+field.widget.settings.og_autocomplete:
+  type: mapping
+  label: 'OG context based entity reference autocomplete with display format settings'
+  mapping:
+    match_operator:
+      type: string
+      label: 'Autocomplete matching'
+    size:
+      type: integer
+      label: 'Size of textfield'
+    placeholder:
+      type: label
+      label: 'Placeholder'

og.links.action.yml

@@ -0,0 +1,11 @@
+og_membership.type_add:
+  route_name: og_membership.type_add
+  title: 'Add membership type'
+  appears_on:
+    - entity.og_membership_type.collection
+
+og_admin.members.add:
+  route_name: og_admin.members.add
+  title: 'Add member'
+  appears_on:
+    - og_admin.members

og.links.menu.yml

@@ -0,0 +1,5 @@
+entity.og_membership_type.collection:
+  title: 'Membership types'
+  parent: system.admin_structure
+  description: 'Create and manage fields, forms, and display settings for OG memberships.'
+  route_name: entity.og_membership_type.collection

og.links.task.yml

@@ -1,2 +1,15 @@
-og.og_admin_routes:
+entity.og_membership.canonical:
+  route_name: entity.og_membership.canonical
+  base_route: entity.og_membership.canonical
+  title: View
+entity.og_membership.edit_form:
+  route_name: entity.og_membership.edit_form
+  base_route: entity.og_membership.canonical
+  title: Edit
+entity.og_membership.delete_form:
+  route_name: entity.og_membership.delete_form
+  base_route: entity.og_membership.canonical
+  title: Delete
+  weight: 10
+og_admin.local_tasks:
   deriver: \Drupal\og\Plugin\Derivative\OgLocalTask

og.module

@@ -17,6 +17,7 @@ use Drupal\og\Entity\OgRole;
 use Drupal\og\Og;
 use Drupal\og\OgGroupAudienceHelperInterface;
 use Drupal\og\OgMembershipInterface;
+use Drupal\og\OgMembershipTypeInterface;
 use Drupal\og\OgRoleInterface;
 use Drupal\system\Entity\Action;
 use Drupal\user\EntityOwnerInterface;
@@ -177,6 +178,47 @@ function og_entity_access(EntityInterface $entity, $operation, AccountInterface
   return AccessResult::forbidden();
 }
 
+/**
+ * Implements hook_ENTITY_TYPE_access().
+ */
+function og_og_membership_type_access(OgMembershipTypeInterface $entity, $operation, AccountInterface $account) {
+  // Do not allow deleting the default membership type.
+  if ($operation === 'delete' && $entity->id() === OgMembershipInterface::TYPE_DEFAULT) {
+    return AccessResult::forbidden();
+  }
+
+  // If the user has permission to administer all groups, allow access.
+  if ($account->hasPermission('administer group')) {
+    return AccessResult::allowed();
+  }
+
+  return AccessResult::forbidden();
+}
+
+/**
+ * Implements hook_ENTITY_TYPE_access().
+ */
+function og_og_membership_access(OgMembershipInterface $entity, $operation, AccountInterface $account) {
+  $group = $entity->getGroup();
+
+  // If there's a group owner, don't let them leave.
+  if (
+    isset($group_fields['uid'])
+    && $operation === 'delete'
+    && $group_fields['uid']->entity->id() === $entity->getOwner()->id()
+  ) {
+    return AccessResult::forbidden();
+  }
+
+  // Ensure that there's at least one member in the group.
+  if ($operation === 'delete' && \Drupal::service('og.membership_manager')->getGroupMembershipCount($group) === 1) {
+    return AccessResult::forbidden();
+  }
+
+  return \Drupal::service('og.access')
+    ->userAccess($entity->getGroup(), 'manage members');
+}
+
 /**
  * Implements hook_entity_create_access().
  */
@@ -242,7 +284,7 @@ function og_entity_bundle_field_info(EntityTypeInterface $entity_type, $bundle,
 
   $fields = [];
   $fields['og_group'] = BaseFieldDefinition::create('og_group')
-    ->setLabel(t('OG Group'))
+    ->setLabel('OG Group')
     ->setComputed(TRUE)
     ->setTranslatable(FALSE)
     ->setDefaultValue(TRUE)