Skip to content

fix(drag-handle-vue-2): fix vue2 warnign about objects as default #6857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdbch merged 2 commits into from
Sep 3, 2025
Merged

fix(drag-handle-vue-2): fix vue2 warnign about objects as default #6857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71ba265
fix(drag-handle-vue-2): use factory function for default
max-nextcloud Aug 21, 2025
a706e4c
Fix prop default handling for Vue 2
bdbch Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/moody-trees-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tiptap/extension-drag-handle-vue-2': patch
---

Use factory function for object default value as required by vue 2.
5 changes: 5 additions & 0 deletions .changeset/serious-tools-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tiptap/extension-drag-handle-vue-2": patch
---

Fixed a bug that would cause Vue 2 to throw errors in console because Vue 2 expects factory functions for prop defaults
2 changes: 1 addition & 1 deletion packages/extension-drag-handle-vue-2/src/DragHandle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const DragHandle = Vue.extend({
props: {
pluginKey: {
type: [String, Object] as PropType<DragHandleProps['pluginKey']>,
default: dragHandlePluginDefaultKey,
default: () => dragHandlePluginDefaultKey,
},

editor: {
Expand Down
Loading