-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(DragHandle): prevent Vue from overriding visibility when locked #7252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(DragHandle): prevent Vue from overriding visibility when locked #7252
Conversation
🦋 Changeset detectedLatest commit: b525e79 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Is this still being worked on, or why hasn't it received a review yet? |
|
@benjamincanac When reviewing pull requests that have already been merged, please ensure that the checklist at the top has been checked off. Failure to do so may result in delays. |
|
resolved conflicts & added a changeset. when tests run through successfully I'll merge it. |
@tiptap/extension-character-count
@tiptap/extension-dropcursor
@tiptap/extension-gapcursor
@tiptap/extension-focus
@tiptap/extension-list-item
@tiptap/extension-history
@tiptap/extension-list-keymap
@tiptap/extension-placeholder
@tiptap/extension-table-cell
@tiptap/extension-table-header
@tiptap/extension-table-row
@tiptap/extension-task-item
@tiptap/extension-task-list
@tiptap/core
@tiptap/extension-audio
@tiptap/extension-blockquote
@tiptap/extension-bold
@tiptap/extension-bullet-list
@tiptap/extension-code
@tiptap/extension-bubble-menu
@tiptap/extension-collaboration
@tiptap/extension-code-block
@tiptap/extension-code-block-lowlight
@tiptap/extension-collaboration-caret
@tiptap/extension-color
@tiptap/extension-details
@tiptap/extension-document
@tiptap/extension-drag-handle
@tiptap/extension-drag-handle-react
@tiptap/extension-drag-handle-vue-2
@tiptap/extension-drag-handle-vue-3
@tiptap/extension-emoji
@tiptap/extension-floating-menu
@tiptap/extension-file-handler
@tiptap/extension-font-family
@tiptap/extension-hard-break
@tiptap/extension-heading
@tiptap/extension-horizontal-rule
@tiptap/extension-image
@tiptap/extension-highlight
@tiptap/extension-invisible-characters
@tiptap/extension-italic
@tiptap/extension-link
@tiptap/extension-mathematics
@tiptap/extension-list
@tiptap/extension-mention
@tiptap/extension-node-range
@tiptap/extension-ordered-list
@tiptap/extension-paragraph
@tiptap/extension-strike
@tiptap/extension-subscript
@tiptap/extension-table
@tiptap/extension-superscript
@tiptap/extension-table-of-contents
@tiptap/extension-text
@tiptap/extension-text-style
@tiptap/extension-text-align
@tiptap/extension-typography
@tiptap/extension-twitch
@tiptap/extension-underline
@tiptap/extension-unique-id
@tiptap/extension-youtube
@tiptap/extensions
@tiptap/markdown
@tiptap/html
@tiptap/react
@tiptap/starter-kit
@tiptap/pm
@tiptap/static-renderer
@tiptap/suggestion
@tiptap/vue-3
@tiptap/vue-2
commit: |
Changes Overview
Fixed drag handle visibility not updating dynamically in Vue 3 component.
Implementation Approach
visibility: 'hidden'from inline styles toonMountedhookvisibilityfrom the style object in render functionTesting Done
I haven't been able to test this in the Vue demo because it uses the
editor.chain().focus().lockDragHandle().run()command which is not available when using thedrag-handle-plugin.tsbut only available in https://github.com/ueberdosis/tiptap/blob/develop/packages/extension-drag-handle/src/drag-handle.ts#L88.I encountered this issue when using the Vue 3 DragHandle component which is why I'm using
.setMeta('lockDragHandle', true)instead.Verification Steps
Additional Notes
The inline style was preventing the plugin from updating visibility. Setting it programmatically instead fixes this.
This was discovered while implementing the Editor component in Nuxt UI.
Checklist
Related Issues