fix: race condition in ReactRenderer

[YousefED]

Changes Overview

There's a race condition that can occur in React StrictMode, that causes an already destroyed renderer to be re-added. This happens because render is called after destroy, and render then calls setRenderer.

Implementation Approach

Keep a destroyed flag and don't call render for already destroyed components

Testing Done

Tested manually

Verification Steps

Additional Notes

Checklist

• I have created a changeset for this PR if necessary.
• My changes do not break the library.
• I have added tests where applicable.
• I have followed the project guidelines.
• I have fixed any lint issues.

Related Issues

[changeset-bot]

🦋 Changeset detected

Latest commit: 19fbdb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 71 packages

Name	Type
@tiptap/react	Patch
@tiptap/extension-drag-handle-react	Patch
@tiptap/core	Patch
@tiptap/extension-blockquote	Patch
@tiptap/extension-bold	Patch
@tiptap/extension-bubble-menu	Patch
@tiptap/extension-bullet-list	Patch
@tiptap/extension-code-block-lowlight	Patch
@tiptap/extension-code-block	Patch
@tiptap/extension-code	Patch
@tiptap/extension-collaboration-caret	Patch
@tiptap/extension-collaboration	Patch
@tiptap/extension-color	Patch
@tiptap/extension-details	Patch
@tiptap/extension-document	Patch
@tiptap/extension-drag-handle-vue-2	Patch
@tiptap/extension-drag-handle-vue-3	Patch
@tiptap/extension-drag-handle	Patch
@tiptap/extension-emoji	Patch
@tiptap/extension-file-handler	Patch
@tiptap/extension-floating-menu	Patch
@tiptap/extension-font-family	Patch
@tiptap/extension-hard-break	Patch
@tiptap/extension-heading	Patch
@tiptap/extension-highlight	Patch
@tiptap/extension-horizontal-rule	Patch
@tiptap/extension-image	Patch
@tiptap/extension-invisible-characters	Patch
@tiptap/extension-italic	Patch
@tiptap/extension-link	Patch
@tiptap/extension-list	Patch
@tiptap/extension-mathematics	Patch
@tiptap/extension-mention	Patch
@tiptap/extension-node-range	Patch
@tiptap/extension-ordered-list	Patch
@tiptap/extension-paragraph	Patch
@tiptap/extension-strike	Patch
@tiptap/extension-subscript	Patch
@tiptap/extension-superscript	Patch
@tiptap/extension-table-of-contents	Patch
@tiptap/extension-table	Patch
@tiptap/extension-text-align	Patch
@tiptap/extension-text-style	Patch
@tiptap/extension-text	Patch
@tiptap/extension-twitch	Patch
@tiptap/extension-typography	Patch
@tiptap/extension-underline	Patch
@tiptap/extension-unique-id	Patch
@tiptap/extension-youtube	Patch
@tiptap/extensions	Patch
@tiptap/html	Patch
@tiptap/markdown	Patch
@tiptap/pm	Patch
@tiptap/starter-kit	Patch
@tiptap/static-renderer	Patch
@tiptap/suggestion	Patch
@tiptap/vue-2	Patch
@tiptap/vue-3	Patch
@tiptap/extension-character-count	Patch
@tiptap/extension-dropcursor	Patch
@tiptap/extension-focus	Patch
@tiptap/extension-gapcursor	Patch
@tiptap/extension-history	Patch
@tiptap/extension-list-item	Patch
@tiptap/extension-list-keymap	Patch
@tiptap/extension-placeholder	Patch
@tiptap/extension-table-cell	Patch
@tiptap/extension-table-header	Patch
@tiptap/extension-table-row	Patch
@tiptap/extension-task-item	Patch
@tiptap/extension-task-list	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	19fbdb0
🔍 Latest deploy log	https://app.netlify.com/projects/tiptap-embed/deploys/695e5035d4a5bd00083fb66c
😎 Deploy Preview	https://deploy-preview-7362--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull request overview

This PR fixes a race condition in ReactRenderer where a component could be rendered after its destroy() method was called. The fix introduces a destroyed flag that prevents the queued microtask render from executing when the renderer has been destroyed.

Key changes:

• Added a destroyed boolean flag to track destruction state
• Added a check for the destroyed flag in the queueMicrotask callback to prevent rendering after destruction
• Set destroyed = true in the destroy() method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[pkg-pr-new]

Open in StackBlitz

@tiptap/extension-character-count

npm i https://pkg.pr.new/@tiptap/extension-character-count@7362

@tiptap/extension-dropcursor

npm i https://pkg.pr.new/@tiptap/extension-dropcursor@7362

@tiptap/extension-focus

npm i https://pkg.pr.new/@tiptap/extension-focus@7362

@tiptap/extension-gapcursor

npm i https://pkg.pr.new/@tiptap/extension-gapcursor@7362

@tiptap/extension-history

npm i https://pkg.pr.new/@tiptap/extension-history@7362

@tiptap/extension-list-item

npm i https://pkg.pr.new/@tiptap/extension-list-item@7362

@tiptap/extension-list-keymap

npm i https://pkg.pr.new/@tiptap/extension-list-keymap@7362

@tiptap/extension-placeholder

npm i https://pkg.pr.new/@tiptap/extension-placeholder@7362

@tiptap/extension-table-cell

npm i https://pkg.pr.new/@tiptap/extension-table-cell@7362

@tiptap/extension-table-header

npm i https://pkg.pr.new/@tiptap/extension-table-header@7362

@tiptap/extension-table-row

npm i https://pkg.pr.new/@tiptap/extension-table-row@7362

@tiptap/extension-task-item

npm i https://pkg.pr.new/@tiptap/extension-task-item@7362

@tiptap/extension-task-list

npm i https://pkg.pr.new/@tiptap/extension-task-list@7362

@tiptap/core

npm i https://pkg.pr.new/@tiptap/core@7362

@tiptap/extension-blockquote

npm i https://pkg.pr.new/@tiptap/extension-blockquote@7362

@tiptap/extension-bold

npm i https://pkg.pr.new/@tiptap/extension-bold@7362

@tiptap/extension-bubble-menu

npm i https://pkg.pr.new/@tiptap/extension-bubble-menu@7362

@tiptap/extension-code

npm i https://pkg.pr.new/@tiptap/extension-code@7362

@tiptap/extension-bullet-list

npm i https://pkg.pr.new/@tiptap/extension-bullet-list@7362

@tiptap/extension-code-block

npm i https://pkg.pr.new/@tiptap/extension-code-block@7362

@tiptap/extension-code-block-lowlight

npm i https://pkg.pr.new/@tiptap/extension-code-block-lowlight@7362

@tiptap/extension-collaboration

npm i https://pkg.pr.new/@tiptap/extension-collaboration@7362

@tiptap/extension-collaboration-caret

npm i https://pkg.pr.new/@tiptap/extension-collaboration-caret@7362

@tiptap/extension-color

npm i https://pkg.pr.new/@tiptap/extension-color@7362

@tiptap/extension-details

npm i https://pkg.pr.new/@tiptap/extension-details@7362

@tiptap/extension-document

npm i https://pkg.pr.new/@tiptap/extension-document@7362

@tiptap/extension-drag-handle

npm i https://pkg.pr.new/@tiptap/extension-drag-handle@7362

@tiptap/extension-drag-handle-react

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-react@7362

@tiptap/extension-drag-handle-vue-2

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-2@7362

@tiptap/extension-drag-handle-vue-3

npm i https://pkg.pr.new/@tiptap/extension-drag-handle-vue-3@7362

@tiptap/extension-emoji

npm i https://pkg.pr.new/@tiptap/extension-emoji@7362

@tiptap/extension-floating-menu

npm i https://pkg.pr.new/@tiptap/extension-floating-menu@7362

@tiptap/extension-file-handler

npm i https://pkg.pr.new/@tiptap/extension-file-handler@7362

@tiptap/extension-font-family

npm i https://pkg.pr.new/@tiptap/extension-font-family@7362

@tiptap/extension-hard-break

npm i https://pkg.pr.new/@tiptap/extension-hard-break@7362

@tiptap/extension-heading

npm i https://pkg.pr.new/@tiptap/extension-heading@7362

@tiptap/extension-highlight

npm i https://pkg.pr.new/@tiptap/extension-highlight@7362

@tiptap/extension-horizontal-rule

npm i https://pkg.pr.new/@tiptap/extension-horizontal-rule@7362

@tiptap/extension-image

npm i https://pkg.pr.new/@tiptap/extension-image@7362

@tiptap/extension-invisible-characters

npm i https://pkg.pr.new/@tiptap/extension-invisible-characters@7362

@tiptap/extension-italic

npm i https://pkg.pr.new/@tiptap/extension-italic@7362

@tiptap/extension-link

npm i https://pkg.pr.new/@tiptap/extension-link@7362

@tiptap/extension-list

npm i https://pkg.pr.new/@tiptap/extension-list@7362

@tiptap/extension-mathematics

npm i https://pkg.pr.new/@tiptap/extension-mathematics@7362

@tiptap/extension-mention

npm i https://pkg.pr.new/@tiptap/extension-mention@7362

@tiptap/extension-node-range

npm i https://pkg.pr.new/@tiptap/extension-node-range@7362

@tiptap/extension-ordered-list

npm i https://pkg.pr.new/@tiptap/extension-ordered-list@7362

@tiptap/extension-paragraph

npm i https://pkg.pr.new/@tiptap/extension-paragraph@7362

@tiptap/extension-subscript

npm i https://pkg.pr.new/@tiptap/extension-subscript@7362

@tiptap/extension-strike

npm i https://pkg.pr.new/@tiptap/extension-strike@7362

@tiptap/extension-superscript

npm i https://pkg.pr.new/@tiptap/extension-superscript@7362

@tiptap/extension-table

npm i https://pkg.pr.new/@tiptap/extension-table@7362

@tiptap/extension-table-of-contents

npm i https://pkg.pr.new/@tiptap/extension-table-of-contents@7362

@tiptap/extension-text

npm i https://pkg.pr.new/@tiptap/extension-text@7362

@tiptap/extension-text-align

npm i https://pkg.pr.new/@tiptap/extension-text-align@7362

@tiptap/extension-text-style

npm i https://pkg.pr.new/@tiptap/extension-text-style@7362

@tiptap/extension-twitch

npm i https://pkg.pr.new/@tiptap/extension-twitch@7362

@tiptap/extension-typography

npm i https://pkg.pr.new/@tiptap/extension-typography@7362

@tiptap/extension-underline

npm i https://pkg.pr.new/@tiptap/extension-underline@7362

@tiptap/extension-unique-id

npm i https://pkg.pr.new/@tiptap/extension-unique-id@7362

@tiptap/extension-youtube

npm i https://pkg.pr.new/@tiptap/extension-youtube@7362

@tiptap/html

npm i https://pkg.pr.new/@tiptap/html@7362

@tiptap/extensions

npm i https://pkg.pr.new/@tiptap/extensions@7362

@tiptap/markdown

npm i https://pkg.pr.new/@tiptap/markdown@7362

@tiptap/pm

npm i https://pkg.pr.new/@tiptap/pm@7362

@tiptap/react

npm i https://pkg.pr.new/@tiptap/react@7362

@tiptap/starter-kit

npm i https://pkg.pr.new/@tiptap/starter-kit@7362

@tiptap/static-renderer

npm i https://pkg.pr.new/@tiptap/static-renderer@7362

@tiptap/vue-2

npm i https://pkg.pr.new/@tiptap/vue-2@7362

@tiptap/suggestion

npm i https://pkg.pr.new/@tiptap/suggestion@7362

@tiptap/vue-3

npm i https://pkg.pr.new/@tiptap/vue-3@7362

commit: f3495b8

[YousefED]

@bdbch I see you self-assigned this. Let me know if there's anything you need from me to move this forward!

[bdbch]

LGTM, thanks!