feat(placeholder): add excludedNodeTypes option to exclude wrapper nodes#7551
Open
clcl777 wants to merge 2 commits intoueberdosis:developfrom
Open
feat(placeholder): add excludedNodeTypes option to exclude wrapper nodes#7551clcl777 wants to merge 2 commits intoueberdosis:developfrom
clcl777 wants to merge 2 commits intoueberdosis:developfrom
Conversation
🦋 Changeset detectedLatest commit: 7c8dc97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
This is the document chage for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
Add
excludedNodeTypesoption to the Placeholder extension to fix duplicate placeholders appearing on wrapper nodes when usingincludeChildren: true.Problem
When using
includeChildren: truewith nested structures like lists, placeholders are shown on all empty descendant nodes, including wrapper nodes (bulletList,listItem) and content nodes (paragraph). This results in visually overlapping placeholders:This is visually confusing and not the intended behavior.
Solution
Add
excludedNodeTypesoption to allow excluding specific node types from showing placeholders:Now only the actual content nodes show placeholders:
Implementation Approach
excludedNodeTypes: string[]option toPlaceholderOptionsinterface with a default value of empty array[]doc.descendants()callback, check if the current node type is inexcludedNodeTypesincludeChildrensettingTesting Done
Added 4 new test cases in
packages/extensions/__tests__/placeholder.spec.ts:includeChildren: falsestops child traversal when node is excludedVerification Steps
<ul><li><p></p></li></ul>includeChildren: trueandexcludedNodeTypes: ['bulletList', 'listItem']bulletListandlistItemdo not havedata-placeholderattributeparagraphhasdata-placeholderattributeAdditional Notes
This fix maintains backward compatibility - the default behavior remains unchanged when
excludedNodeTypesis not specified.Checklist
Related Issues
steven-tey/novel#510