Conversation
…eam with store number = 77
There was a problem hiding this comment.
Pull request overview
This PR fixes an error that occurred when file previews were not generated for bitstreams with store_number = 77 (the synchronized storage service identifier). The fix adds support for retrieving files from synchronized storage when generating file previews.
Changes:
- Added a new
retrieveFile()method override inSyncBitstreamStorageServiceImplto properly handle file retrieval for synchronized bitstreams - Created a new integration test
testPreviewWithSyncStorage()to verify preview generation works with synchronized storage - Added a test helper method
withBitstream()inWorkspaceItemBuilderto create bitstreams with specific store numbers for testing
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dspace-api/src/test/resources/org/dspace/scripts/filepreview/logos.tgz | Test resource file (binary compressed archive) for sync storage test |
| dspace-api/src/test/java/org/dspace/scripts/filepreview/FilePreviewIT.java | Added new test for preview generation with sync storage and refactored existing test |
| dspace-api/src/test/java/org/dspace/builder/WorkspaceItemBuilder.java | Added builder method to create bitstreams with specific store numbers |
| dspace-api/src/main/java/org/dspace/storage/bitstore/SyncBitstreamStorageServiceImpl.java | Added retrieveFile() method and removed SQLException from retrieve() signature |
dspace-api/src/main/java/org/dspace/storage/bitstore/SyncBitstreamStorageServiceImpl.java
Outdated
Show resolved
Hide resolved
dspace-api/src/test/java/org/dspace/scripts/filepreview/FilePreviewIT.java
Outdated
Show resolved
Hide resolved
|
Backport branch created but failed to create PR. Please create the PR manually: Or via GitHub CLI: gh pr create --repo dataquest-dev/dspace --base dtq-dev --head ufal:backport-1318-to-dtq-dev --title "[Port dtq-dev] Issue 1313: fixed error when file preview is not generated for bitstream with store_number = 77" --body "Port of #1318 by @kuchtiak-ufal to `dtq-dev`."(see action log for full error response) |
milanmajchrak
pushed a commit
to dataquest-dev/DSpace
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.