Skip to content

Fix checking of miniscope_split #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpandreotti merged 1 commit into from
Feb 11, 2026
Merged

Fix checking of miniscope_split #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions carcara/src/checker/rules/quantifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,13 @@ pub fn miniscope_split(RuleArgs { conclusion, pool, .. }: RuleArgs) -> RuleResul

let mut bindings_set: IndexSet<_> = bindings.iter().collect();
for (phi, right) in phis.iter().zip(right_args) {
// `right` is the same as `phi`, it must have no bound variables from the quantifier being
// split, which is checked afterwards.
if phi == right {
continue;
}
// Otherwise an appropriate binder must have been put around `right` and its variables must
// be from the bindings_set in the LHS of the conclusion
let (inner_bindings, inner) = match op {
Operator::Or => match_term_err!((forall ... phi) = right)?,
Operator::And => match_term_err!((exists ... phi) = right)?,
Expand Down