Skip to content

Comments

Add fixes for Rare-List#111

Open
caotic123 wants to merge 50 commits intoufmg-smite:mainfrom
caotic123:rare-checking
Open

Add fixes for Rare-List#111
caotic123 wants to merge 50 commits intoufmg-smite:mainfrom
caotic123:rare-checking

Conversation

@caotic123
Copy link
Contributor

@caotic123 caotic123 commented Feb 11, 2026

There are still some modifications that were left for rare-checking, strictly for rare-list checking.
Also, some rules are missing in get_rules to normalize the rare list for unary operations.

tiago.campos.ferreira and others added 30 commits May 24, 2025 07:02
Add rare parsing
63f28f7
Format coding
02a5fbf
Format code
5cdc514
fix lints problems
ea84849
Fix paramsort and array/bitvec conversion
db97e4c
Fix clippy problems
411380a
Format code
d0c21a5
Fix comment
5701fac
tests in rules/mod
2301db2
Fix typo
f27d3f3
Fix bvconcat compute sort
4aea3d1
@caotic123 @bpandreotti
Update rust-toolchain.toml
9fc2506 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Update to disable multi arguments lint in carcara/src/lib.rs
7834a36 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Update carcara/src/lib.rs
78544aa 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
Remove duplicated eo
7bdc843
@caotic123 @bpandreotti
Update carcara/src/parser/rare/mod.rs
be9be2d 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
Add rare parser as impl extension
001a333
Format code
ccb4188
Merge branch 'main' into rare-parsing
d7f2b06
Add missing comma
919816b
Remove tests rare file
a0c4cd4
Add rare checking
81e2776
Fix clippy warnings
2b10cf6
Merge branch 'main' into rare-checking
ba030f9
fix clippy warning
4d48a8e
Fix more clippy warnings
757f022
Fix format
6a8e271
@caotic123 @bpandreotti
Update carcara/src/elaborator/hole.rs
bf7bd46 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Update carcara/src/elaborator/lia_generic.rs
68290a4 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Update carcara/src/checker/rules/rare.rs
c24acc1 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
caotic123 and others added 15 commits December 19, 2025 18:52
@caotic123 @bpandreotti
Create substitution just once carcara/src/checker/rules/rare.rs
ef5a82d 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Reuse substitution carcara/src/checker/rules/rare.rs
4a68153 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
@caotic123 @bpandreotti
Update carcara/src/checker/rules/rare.rs
ec7b413 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
Merge branch 'main' into rare-checking
8032777
Add docs for rare
bad493b
Fix polysort bug in subs
4eceb7e
Merge branch 'main' into rare-checking
625a92b
Format
9c21334
@caotic123 @bpandreotti
Update carcara/src/ast/substitution.rs
3d60912 
Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>
Move fixes for rare-lsits
2797565
Add fixes for subs in rare-list
459ae0d
Fix cargo lint
37886da
Remove two-level rare-list checking
982ef3b
Remove two-level rare-list checking
b0ca0c0
Add tests for rare-list
cd6a65f
@caotic123 caotic123 changed the title Add fixex for Rare-List Add fixes for Rare-List Feb 11, 2026
HanielB added a commit to HanielB/carcara that referenced this pull request Feb 12, 2026
@HanielB
Merge from Tiago's PR ufmg-smite#111
e25cb37 
Squashed commit of the following:

commit 065db11
Merge: cd6a65f 2b9b4b2
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 19:31:19 2026 -0300

    Mergw with main

commit cd6a65f
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 18:58:21 2026 -0300

    Add tests for rare-list

commit b0ca0c0
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 18:51:21 2026 -0300

    Remove two-level rare-list checking

commit 982ef3b
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 18:51:06 2026 -0300

    Remove two-level rare-list checking

commit 37886da
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 18:45:40 2026 -0300

    Fix cargo lint

commit 459ae0d
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 18:43:28 2026 -0300

    Add fixes for subs in rare-list

commit 2797565
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Feb 11 17:53:05 2026 -0300

    Move fixes for rare-lsits

commit 3d60912
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Tue Jan 27 13:05:44 2026 -0300

    Update carcara/src/ast/substitution.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 9c21334
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Jan 21 18:09:38 2026 -0300

    Format

commit 625a92b
Merge: 4eceb7e 94040b8
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Jan 21 17:40:31 2026 -0300

    Merge branch 'main' into rare-checking

commit 4eceb7e
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Jan 21 17:38:20 2026 -0300

    Fix polysort bug in subs

commit bad493b
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Fri Dec 19 20:01:52 2025 -0300

    Add docs for rare

commit 8032777
Merge: ec7b413 961cde2
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Fri Dec 19 19:35:31 2025 -0300

    Merge branch 'main' into rare-checking

commit ec7b413
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:53:57 2025 -0300

    Update carcara/src/checker/rules/rare.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 4a68153
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:52:37 2025 -0300

    Reuse substitution carcara/src/checker/rules/rare.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit ef5a82d
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:52:16 2025 -0300

    Create substitution just once carcara/src/checker/rules/rare.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit c24acc1
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:51:55 2025 -0300

    Update carcara/src/checker/rules/rare.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 68290a4
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:51:46 2025 -0300

    Update carcara/src/elaborator/lia_generic.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit bf7bd46
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Fri Dec 19 18:51:38 2025 -0300

    Update carcara/src/elaborator/hole.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 6a8e271
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 16:21:48 2025 -0300

    Fix format

commit 757f022
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 16:20:05 2025 -0300

    Fix more clippy warnings

commit 4d48a8e
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 16:12:33 2025 -0300

    fix clippy warning

commit ba030f9
Merge: 2b10cf6 b685c15
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 16:00:10 2025 -0300

    Merge branch 'main' into rare-checking

commit 2b10cf6
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 15:52:01 2025 -0300

    Fix clippy warnings

commit 81e2776
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Sun Nov 30 15:48:21 2025 -0300

    Add rare checking

commit a0c4cd4
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 13:28:02 2025 -0300

    Remove tests rare file

commit 919816b
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 13:27:24 2025 -0300

    Add missing comma

commit d7f2b06
Merge: ccb4188 97f8272
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 13:21:38 2025 -0300

    Merge branch 'main' into rare-parsing

commit ccb4188
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 12:18:03 2025 -0300

    Format code

commit 001a333
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 12:11:35 2025 -0300

    Add rare parser as impl extension

commit be9be2d
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Wed Oct 22 09:47:06 2025 -0300

    Update carcara/src/parser/rare/mod.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 7bdc843
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Wed Oct 22 09:36:39 2025 -0300

    Remove duplicated eo

commit 78544aa
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Wed Oct 22 09:34:47 2025 -0300

    Update carcara/src/lib.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 7834a36
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Wed Oct 22 09:34:37 2025 -0300

    Update to disable multi arguments lint in carcara/src/lib.rs

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 9fc2506
Author: Tiago Campos <itotimcampos@windowslive.com>
Date:   Wed Oct 22 09:34:02 2025 -0300

    Update rust-toolchain.toml

    Co-authored-by: Bruno Andreotti <bandreotti@protonmail.com>

commit 4aea3d1
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Mon Jul 21 19:40:27 2025 -0300

    Fix bvconcat compute sort

commit f27d3f3
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 22:39:41 2025 -0300

    Fix typo

commit 2301db2
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 03:51:58 2025 -0300

    tests in rules/mod

commit 5701fac
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 03:48:42 2025 -0300

    Fix comment

commit d0c21a5
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 03:47:46 2025 -0300

    Format code

commit 411380a
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 03:46:32 2025 -0300

    Fix clippy problems

commit db97e4c
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Thu Jul 17 03:43:55 2025 -0300

    Fix paramsort and array/bitvec conversion

commit ea84849
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Tue Jun 10 11:33:44 2025 -0300

    fix lints problems

commit 5cdc514
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Tue Jun 10 11:15:00 2025 -0300

    Format code

commit 02a5fbf
Author: Tiago Campos <tiagocampos@mixrank.com>
Date:   Tue Jun 10 11:14:29 2025 -0300

    Format coding

commit 63f28f7
Author: tiago.campos.ferreira <tiagocampos@mixrank.com>
Date:   Sat May 24 07:02:36 2025 -0300

    Add rare parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@caotic123