Open
Conversation
bpandreotti
reviewed
Feb 12, 2026
Comment on lines
+1116
to
+1133
| impl Operator { | ||
| pub fn is_assoc(&self) -> bool { | ||
| match self { | ||
| Operator::And | ||
| | Operator::Or | ||
| | Operator::Add | ||
| | Operator::Mult | ||
| | Operator::BvAdd | ||
| | Operator::BvOr | ||
| | Operator::BvMul | ||
| | Operator::BvAnd | ||
| | Operator::BvXor | ||
| | Operator::BvConcat => true, | ||
| _ => false, | ||
| } | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Are these necessarily only the associative operators that aci_simp supports (e.g. div is left-associative but is not included here)? If so, I think it's better to keep this logic in the aci_simp function since it's only used there. If not, we can use the nary_case method instead, which contemplates all operators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.