Skip to content

Purge Hycom; Add HAFS IntelLLVM test#3145

Open
DeniseWorthen wants to merge 17 commits intoufs-community:developfrom
DeniseWorthen:feature/purgehycom
Open

Purge Hycom; Add HAFS IntelLLVM test#3145
DeniseWorthen wants to merge 17 commits intoufs-community:developfrom
DeniseWorthen:feature/purgehycom

Conversation

@DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 13, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

Removes the HYCOM component and adds an InteLLVM HAFS test for the fully coupled configuration.

Commit Message:

* UFSWM - Remove HYCOM-interface and HYCOM source code and test files
* UFSWM - Add HAFS IntelLLVM control and debug test for MOM6 configuration
  * CMEPS - Remove code associated with previous hafs coupling mode; rename previous hafs.mom6 coupling mode to hafs

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update required.
    • Relevant updates are included with this PR.
    • A WM issue has been opened to track the need for a documentation update; a person responsible for submitting the update has been assigned to the issue (link issue).

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.
  • PR Adds Baselines

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

DeniseWorthen and others added 4 commits March 11, 2026 09:22
FAILED: TEST TIMED OUT -- TEST 'hafs_regional_atm_wav_intel' [, ]( MB)
FAILED: TEST TIMED OUT -- TEST 'hafs_regional_docn_intel' [, ]( MB)
FAILED: TEST TIMED OUT -- TEST 'hafs_regional_docn_oisst_intel' [, ]( MB)

Probably need to send sst to atm by default (needed either docn or
mom6) and fix the wav fields too.
@gspetro-NOAA
Copy link
Collaborator

gspetro-NOAA commented Mar 13, 2026

@jdkublnick has noted that a documentation update will be needed when HYCOM is removed. @DeniseWorthen if you were not already planning to incorporate that into the PR, then we will at least need to coordinate with Josh's team to ensure that an update happens around the same time.

@DeniseWorthen
Copy link
Collaborator Author

I'm happy to include a documentation update. This issue has been around for >6 months, so happy to include the work that EPIC is done in preparation for this.

@DeniseWorthen DeniseWorthen linked an issue Mar 13, 2026 that may be closed by this pull request
@gspetro-NOAA
Copy link
Collaborator

I'm happy to include a documentation update. This issue has been around for >6 months, so happy to include the work that EPIC is done in preparation for this.

I'm not sure that work has been done yet on the docs, but it can be prepared. @jdkublnick is that right?

@jdkublnick
Copy link
Contributor

I'm happy to include a documentation update. This issue has been around for >6 months, so happy to include the work that EPIC is done in preparation for this.

I'm not sure that work has been done yet on the docs, but it can be prepared. @jdkublnick is that right?

Correct, I haven't done any work yet, but it's a quick change regardless. I can get the docs prepared sometime early next week. Thank you! @DeniseWorthen @gspetro-NOAA

DeniseWorthen and others added 4 commits March 18, 2026 11:49
rt_hafs_regional_atm_wav_intel.log:Test hafs_regional_atm_wav_intel FAIL
rt_hafs_regional_docn_intel.log:Test hafs_regional_docn_intel FAIL
rt_hafs_regional_docn_oisst_intel.log:Test hafs_regional_docn_oisst_intel FAIL
@DeniseWorthen DeniseWorthen changed the title Purge Hycom Purge Hycom; Add HAFS IntelLLVM test Mar 19, 2026
@DeniseWorthen
Copy link
Collaborator Author

@jdkublnick I will be opening this PR today, once the final run on URSA has generated the logs.

@DeniseWorthen DeniseWorthen marked this pull request as ready for review March 20, 2026 15:37
@gspetro-NOAA gspetro-NOAA added Baseline Updates Current baselines will be updated. New Baselines New baselines will be added to project. labels Mar 20, 2026
@gspetro-NOAA gspetro-NOAA added the CMEPS There are changes to the CMEPS component repository. label Mar 20, 2026
@gspetro-NOAA
Copy link
Collaborator

@DeniseWorthen In your commit message, is one of those (2nd one?) meant to say CMEPS instead of UFSWM?

@DeniseWorthen
Copy link
Collaborator Author

@gspetro-NOAA I had actually forgotten to add a commit message for the CMEPS PR; I've added it now.

@jdkublnick
Copy link
Contributor

@gspetro-NOAA @DeniseWorthen I have opened the accompanying documentation PR for these changes here: #3157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Updates Current baselines will be updated. CMEPS There are changes to the CMEPS component repository. New Baselines New baselines will be added to project.

Projects

Status: Evaluating

Development

Successfully merging this pull request may close these issues.

Add IntelLLVM test for fully coupled HAFs configuration Purge HYCOM Purge Hycom

3 participants