Skip to content

Update the LIST_FILES in the c1152 regression tests // Source control_sfs test for debug and restart tests (#3151)#3147

Open
dpsarmie wants to merge 14 commits intoufs-community:developfrom
dpsarmie:fix/c1152_LISTFILES_update
Open

Update the LIST_FILES in the c1152 regression tests // Source control_sfs test for debug and restart tests (#3151)#3147
dpsarmie wants to merge 14 commits intoufs-community:developfrom
dpsarmie:fix/c1152_LISTFILES_update

Conversation

@dpsarmie
Copy link
Collaborator

@dpsarmie dpsarmie commented Mar 16, 2026

Commit Queue Requirements:

  • This PR addresses a relevant WM issue (if not, create an issue).
  • All subcomponent pull requests (if any) have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
    • Commit log file w/full results from RT suite run (if applicable).
    • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
  • Fill out all sections of this template.

Description:

#3147

This PR will update the c1152 regression test files to populate the list of files that should be checked whenever the regression tests are run. The output and restart frequency between WCOSS2 and the other RDHPC systems were different, so those outputs were also modified so one set of files could be tested across all platforms.

#3151

Updates the cpld_restart_sfs and cpld_debug_sfs tests to source the cpld_control_sfs tests and modify only the required atparse variables.

Commit Message:

* UFSWM - Update C1152 LIST_FILES variable
* UFSWM - modify restart and debug tests for SFS to source the control test for export settings

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Documentation:

  • Documentation update NOT required.

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes since c1152 are not a part of the rt.conf.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Orion
    • Hercules
    • GaeaC6
    • Derecho
    • Ursa
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@dpsarmie dpsarmie marked this pull request as ready for review March 18, 2026 19:59
@dpsarmie
Copy link
Collaborator Author

Failure on cpld_warmstart_c12_9deg_intel on the Ursa RT run. Probably a random failure but rerunning the individual case.

@gspetro-NOAA gspetro-NOAA added the No Baseline Change No Baseline Change label Mar 19, 2026
@gspetro-NOAA gspetro-NOAA moved this from Evaluating to Review in PRs to Process Mar 19, 2026
@gspetro-NOAA gspetro-NOAA moved this from Review to Schedule in PRs to Process Mar 20, 2026
@gspetro-NOAA gspetro-NOAA added the On Deck This is the next PR in line for testing/merge. label Mar 20, 2026
@gspetro-NOAA
Copy link
Collaborator

@dpsarmie We'd like to combine this PR w/ WM PR #3151 . Additionally, this PR might be a good candidate to combine in NOAA-EMC/ufsatm#1066, which is a small, documentation-only PR for UFSATM.

@gspetro-NOAA gspetro-NOAA changed the title Update the LIST_FILES in the c1152 regression tests Update the LIST_FILES in the c1152 regression tests // Source control_sfs test for debug and restart tests (#3151) Mar 20, 2026
@gspetro-NOAA
Copy link
Collaborator

@dpsarmie Could you push an empty test_changes.list?

@dpsarmie
Copy link
Collaborator Author

@dpsarmie Could you push an empty test_changes.list?

Ok I updated the file!

@gspetro-NOAA gspetro-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. In Testing The PR that is currently in testing stages and removed On Deck This is the next PR in line for testing/merge. labels Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In Testing The PR that is currently in testing stages No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.

Projects

Status: Schedule

Development

Successfully merging this pull request may close these issues.

Update format of SFS restart and debug tests to source control test Add LIST_FILES to the c1152 regression test files

2 participants