Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,26 @@ on:
- master
pull_request:

env:
NODE_OPTIONS: --openssl-legacy-provider
Comment on lines +9 to +10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed for old webpack + node 18


jobs:
ci:
needs: [test, downstream]
runs-on: ubuntu-latest
steps:
- run: true
test:
name: yarn test
name: npm test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install Dependencies
run: yarn install --pure-lockfile
run: npm ci
- name: Check Peer Dependencies
run: npx check-peer-dependencies
- name: Run Tests
run: yarn test
run: npm test

downstream:
name: Test downstream ${{ matrix.group }} projects
Expand All @@ -34,10 +37,9 @@ jobs:
- uses: actions/checkout@v2
- name: Prepare to Test Downstream Projects
run: |
npm config set scripts-prepend-node-path auto
git config --global user.email uirouter@github.actions
git config --global user.name uirouter_github_actions
- name: Install Dependencies
run: yarn install --pure-lockfile
run: npm ci
- name: Test Downstream Projects
run: yarn test:downstream --group ${{ matrix.group }}
run: npm run test:downstream -- --group ${{ matrix.group }}
4 changes: 2 additions & 2 deletions examples/create-react-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ Example showing sticky states installed in a create-react-app app.
## Running

```
yarn install
yarn start
npm install
npm start
```
18 changes: 13 additions & 5 deletions examples/create-react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,23 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@uirouter/react": "^0.6.2",
"@uirouter/react": "^1.0.7",
"@uirouter/dsr": "^1.0.2",
"@uirouter/visualizer": "^6.0.0",
"react": "^16.2.0",
"react-dom": "^16.2.0"
"@uirouter/visualizer": "^7.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"devDependencies": {
"@uirouter/cypress-runner": "^1.0.2",
"react-scripts": "1.1.1"
"react-scripts": "5.0.1"
},
"checkPeerDependencies": {
"ignore": [
"ajv",
"picomatch",
"typescript",
"yaml"
]
Comment on lines +16 to +22
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore these peer deps, these fail during a npx check-peer-dependencies when react-scripts is in the project at all 🤦

},
"scripts": {
"start": "react-scripts start",
Expand Down
5 changes: 3 additions & 2 deletions examples/create-react-app/src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import ReactDOM from 'react-dom';
import { createRoot } from 'react-dom/client';
import App from './App';

ReactDOM.render(React.createElement(App), document.getElementById('root'));
const root = createRoot(document.getElementById('root'));
root.render(React.createElement(App));
Loading