Skip to content

Add missing return statement to copyToClipboard util #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MorisR
Copy link

@MorisR MorisR commented Jul 28, 2025

While using the useCopyToClipboard hook I noticed that the 2nd argument returned by the hook (the copyToClipboard callback) does not match the typescript signature.

usehooks/index.d.ts

Lines 126 to 129 in 945436d

export function useCopyToClipboard(): [
string | null,
(value: string) => Promise<void>
];

By adding a return before the handleCopy function call, the callback now returns the promise, which now allows you to chain a .then() and .catch() to it, while previously it used to throw

image

While using the `useCopyToClipboard` I noticed that the 2nd argument returned by the hook (the `copyToClipboard` callback) does not match the typescript signature.
@MorisR
Copy link
Author

MorisR commented Jul 28, 2025

Hey @tylermcginnis can you have a quick 👀 please?


Update:
Sorry for the causal message 😅 (it didn't dawn on me that it might be a bit rude and a bit too direct), would appreciate your help here! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant