Skip to content

Module customisation#5

Open
gareth-e wants to merge 16 commits intoukncsc:mainfrom
uktrade:module-customisation
Open

Module customisation#5
gareth-e wants to merge 16 commits intoukncsc:mainfrom
uktrade:module-customisation

Conversation

@gareth-e
Copy link
Copy Markdown

@gareth-e gareth-e commented Aug 3, 2022

Applies the following changes:

  • Updates some functions and resources to remove Terraform deprecation warnings.
  • Removes the need to provide the Zone Name and ID (since a data source lookup is used anyway).
  • Adds a secondary provider to resources can be deployed to local regions.
  • Adds a default tag, and adds tagging to all taggable resources.
  • Add variables for CloudFront price class and WAF configuration.
  • Reconfigures the policy file resource to use a template file. Adds the template file to this repo.
  • Updates to readme to include these changes.

gareth-e added 16 commits August 2, 2022 10:58
@gareth-e
Add bucket name namespace for ordering STS buckets
328bcde
@gareth-e
Remove provider and pass from parent TF
dfb8f08
@gareth-e
Add provider to aws_caller_identity
ce0ab14
@gareth-e
Add provider argument to all resources
5ecbbba
@gareth-e
Add aws_s3_bucket_acl resource to resolve warning.
df834de 
Resolves TF warning:
Argument is deprecated
in resource "aws_s3_bucket" "policybucket":
│     acl      = "private"
Use the aws_s3_bucket_acl resource instead
@gareth-e
Add provider configuration_aliases
354b253
@gareth-e
Replace aws_s3_bucket_object due to deprecation
bca72a5 
Resolves warning:
Argument is deprecated
in resource "aws_s3_bucket_object" "mtastspolicyfile":
│   key          = ".well-known/mta-sts.txt"
Use the aws_s3_object resource instead
@gareth-e
Removing zone_id input variable since not required
41f5bb7 
Previously, zone name and ID were both passed in. Since
using aws_route53_zone data source anyway, can drop one.
Now looking up using domain name.
@gareth-e
Update readme with secondary provider details.
252577a
@gareth-e
Combine locals blocks into one and sort vars.
d290ad7
@gareth-e
Add default "Service" and "Domain" tags.
41f4d61
@gareth-e
Tag all taggable resources.
5a82e77
@gareth-e
Add CloudFront price-class variable.
98e2ab9
@gareth-e
Add CloudFront WAF ACL variable.
134ccb6
@gareth-e
Update S3 object inline heredoc to templatefile
7fc23a9
@gareth-e
Add optional variable examples.
7941182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gareth-e