Conversation
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Good reliability improvement overall and the intent is solid. One important robustness issue remains: the new zero-check uses direct dict indexing and can fail on partial/malformed API responses; switching to .get() will make this guard safe in the failure scenarios it is meant to handle.
💬 Posted 1 inline comment
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review 3
Made with ❤️ by Ultralytics Actions
Looks clean. The new guard at lines 264–269 correctly prevents overwriting recent PyPI metrics with likely transient all-zero API responses while preserving existing merge behavior for normal cases. No blocking issues found in the provided diff.
|
🎉 Huge congratulations on the merge, @glenn-jocher — this is a thoughtful and high-impact reliability improvement! Your safeguard in Really appreciate the care and clarity you brought here. 🙌 |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🛠️ This PR improves PyPI stats reliability in
fetch_stats.pyby preventing accidental overwrites with all-zero recent download data, which is often caused by temporary API failures.📊 Key Changes
last_day,last_week,last_month).0in fresh API data.safe_merge) remains unchanged.🎯 Purpose & Impact